GNOME Bugzilla – Bug 783563
extensions: Make placeholder actually show up
Last modified: 2017-06-08 20:53:34 UTC
See patch.
Created attachment 353418 [details] [review] extensions: Make placeholder actually show up Tweak tool automatically filters out empty tweak groups, which means the extension tweak is hidden altogether when no extensions are installed rather than showing the placeholder as intended. Work around this by making the placeholder itself a tweak, so the group is never considered empty.
Created attachment 353420 [details] Screenshot: Tweak Tool on Kubuntu after patch 353418 applied Could you make it so that the Extensions panel does not show up if GNOME Shell is not running? This worked before the patch you posted here. I'm attaching a screenshot of what it looks like in KDE Plasma after your patch. I tested with Kubuntu 17.10 Alpha daily: http://cdimage.ubuntu.com/kubuntu/daily-live/current/ sudo apt install gnome-tweak-tool gnome-shell-extension-dashtodock Tweak Tool's modules are currently installed to /usr/lib/python3/dist-packages/gtweak/ While I doubt GNOME Tweak Tool is popular with KDE Plasma users, it is used in other environments like MATE or Budgie.
Created attachment 353424 [details] [review] extensions: Bail out early when not running under GNOME GNOME Shell extensions aren't useful in non-GNOME environments, so return right after initializing the empty tweak group to make sure it is kept hidden in that case.
Review of attachment 353418 [details] [review]: Thanks! By the way, many users will already have some extensions installed (perhaps the distro installs GNOME Classic or specific extensions by default like is being proposed for Ubuntu 17.10). When you updated the Extensions page, you also removed the Get more extensions link from the bottom of the page. Maybe it's worth bringing it back, except pointed at GNOME Software instead of the website.
Review of attachment 353424 [details] [review]: Thanks!
(In reply to Jeremy Bicha from comment #4) > When you updated the Extensions page, you also removed the Get more extensions > link from the bottom of the page. Maybe it's worth bringing it back That's really a question for the design team, my patches were simply following https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/tweak-tool/tweak-tool-wires.png
Attachment 353418 [details] pushed as 3e95c35 - extensions: Make placeholder actually show up Attachment 353424 [details] pushed as 1e9b9ef - extensions: Bail out early when not running under GNOME