Bug 783551 – gst-validate-launcher aborts in call to "which" when gst-rtsp-server not installed

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 783551 - gst-validate-launcher aborts in call to "which" when gst-rtsp-server not installed


Summary:	gst-validate-launcher aborts in call to "which" when gst-rtsp-server not inst...


Status:	RESOLVED FIXED

Product:	GStreamer
Classification:	Platform
Component:	gst-devtools
Version:	git master
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	1.13.1
Assigned To:	GStreamer Maintainers
QA Contact:	GStreamer Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2017-06-08 16:12 UTC by U. Artie Eoff
Modified:	2017-06-08 16:19 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
validate:launcher: Do not which(None), the rtsp-server command is unset if not avalaible (1.18 KB, patch) 2017-06-08 16:16 UTC, Thibault Saunier	committed	Details \| Review

Description U. Artie Eoff 2017-06-08 16:12:45 UTC

AFAICT, gst-validate-launcher should be able to run without gst-rtsp-server.  However, if validate is compiled without gst-rtsp-server support, then gst-validate-launcher program fails to run at all.

gst-devtools (master) heads/master-0-g6772fa7d275b

gst-validate-launcher validate --sync
gst-validate-launcher validate --sync --validate-disable-rtsp 1

Traceback (most recent call last):

+ Trace 237559

File "/home/uaeoff/Work/workspace/media/install/bin/gst-validate-launcher", line 69 in <module>
```
exit(main(libsdir))
```
File "/home/uaeoff/Work/workspace/media/install/lib/gst-validate-launcher/python/launcher/main.py", line 568 in main
```
if tests_launcher.needs_http_server() or options.httponly is True:
```
File "/home/uaeoff/Work/workspace/media/install/lib/gst-validate-launcher/python/launcher/baseclasses.py", line 1651 in needs_http_server
```
if tester.needs_http_server():
```
File "/home/uaeoff/Work/workspace/media/install/lib/gst-validate-launcher/python/launcher/apps/gstvalidate.py", line 915 in needs_http_server
```
for test in self.list_tests():
```
File "/home/uaeoff/Work/workspace/media/install/lib/gst-validate-launcher/python/launcher/apps/gstvalidate.py", line 794 in list_tests
```
for test in generator.generate_tests(uris, scenarios):
```
File "/home/uaeoff/Work/workspace/media/install/lib/gst-validate-launcher/python/launcher/apps/gstvalidate.py", line 214 in generate_tests
```
uri_minfo_special_scenarios, scenarios)
```
File "/home/uaeoff/Work/workspace/media/install/lib/gst-validate-launcher/python/launcher/baseclasses.py", line 1335 in generate_tests
```
self.populate_tests(uri_minfo_special_scenarios, scenarios)
```
File "/home/uaeoff/Work/workspace/media/install/lib/gst-validate-launcher/python/launcher/apps/gstvalidate.py", line 293 in populate_tests
```
test_rtsp = which(GST_VALIDATE_RTSP_SERVER_COMMAND)
```
File "/home/uaeoff/Work/workspace/media/install/lib/gst-validate-launcher/python/launcher/utils.py", line 112 in which
```
p = os.path.join(p, name)
```
File "/usr/lib64/python3.5/posixpath.py", line 89 in join
```
genericpath._check_arg_types('join', a, *p)
```
File "/usr/lib64/python3.5/genericpath.py", line 143 in _check_arg_types
```
(funcname, s.__class__.__name__)) from None
```

TypeError: join() argument must be str or bytes, not 'NoneType'

Comment 1 Thibault Saunier 2017-06-08 16:16:52 UTC

Created attachment 353404 [details] [review]
validate:launcher: Do not which(None), the rtsp-server command is unset if not avalaible

Comment 2 Thibault Saunier 2017-06-08 16:18:43 UTC

Attachment 353404 [details] pushed as 543e7a9 - validate:launcher: Do not which(None), the rtsp-server command is unset if not avalaible