After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783526 - timezone: AM/PM format should always be available
timezone: AM/PM format should always be available
Status: RESOLVED FIXED
Product: gnome-initial-setup
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Initial Setup maintainer(s)
GNOME Initial Setup maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-06-07 19:01 UTC by Cosimo Cecchi
Modified: 2017-06-12 16:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
timezone: AM/PM format should always be available (2.46 KB, patch)
2017-06-07 19:01 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2017-06-07 19:01:03 UTC 
See patch.
Comment 1 Cosimo Cecchi 2017-06-07 19:01:15 UTC 
Created attachment 353357 [details] [review]
timezone: AM/PM format should always be available

This is equivalent to
https://git.gnome.org/browse/gnome-control-center/commit/panels/datetime?id=85cd910af5e021f4ad1e34b4ae539a38aa712a61
for gnome-initial-setup.
Comment 2 Rui Matos 2017-06-12 15:17:42 UTC 
Review of attachment 353357 [details] [review]:

otherwise looks good, thanks

::: gnome-initial-setup/pages/timezone/gis-timezone-page.c
@@ -389,3 @@
 
-  ampm = nl_langinfo (AM_STR);
-  if (ampm == NULL || ampm[0] == '\0')

the 'ampm' variable can be dropped too
Comment 3 Cosimo Cecchi 2017-06-12 16:36:59 UTC 
Thanks, pushed with that fixed.

Attachment 353357 [details] pushed as 57b8652 - timezone: AM/PM format should always be available