GNOME Bugzilla – Bug 783501
Provide GstPreset for vaapi encoders.
Last modified: 2018-11-03 15:50:03 UTC
There's GstPreset supported in gstreamer. If we support this for vaapi encoders, I expect this can be involved to gst-validate scenario for vaapi.(bug #773304) Eg. If we have "Main" preset for main profile with dct8x8 disabled, gst-launch-1.0 videotestsrc num-buffers=50 ! encodebin profile="video/quicktime,varient=iso:video/x-h264+Main" ! filesink location=test.mp4 and we can also include preset to gst-validate tools as the following: gst-validate-transcoding-1.0 -o "video/quicktime,variant=iso;:video/x-h264+Main" [input] [output]
That would indeed be nice to add, but you should try to have the same profiles as x264enc: https://phabricator.freedesktop.org/diffusion/GSTUGLY/browse/master/ext/x264/GstX264Enc.prs GstValidate and encodebin serialization format do support presets, we might want to start using some in the default testsuites.
(In reply to Thibault Saunier from comment #1) > That would indeed be nice to add, but you should try to have the same > profiles as x264enc: > https://phabricator.freedesktop.org/diffusion/GSTUGLY/browse/master/ext/x264/ > GstX264Enc.prs Yes I know this preset and have tried with this. But there's some different properties. Anyway we can refer to this preset. > > GstValidate and encodebin serialization format do support presets, we might > want to start using some in the default testsuites. Good information. Thanks.
(In reply to Hyunjun Ko from comment #2) > (In reply to Thibault Saunier from comment #1) > > That would indeed be nice to add, but you should try to have the same > > profiles as x264enc: > > https://phabricator.freedesktop.org/diffusion/GSTUGLY/browse/master/ext/x264/ > > GstX264Enc.prs > Yes I know this preset and have tried with this. But there's some different > properties. Anyway we can refer to this preset. Hmm, probably we should use same profile name to generalize for gst-validate.
Created attachment 354723 [details] Initial propose for GstVaapiEncodeH264.prs Now I would propose initial version of GstVaapiEncodeH264.prs including: - Profile Baseline - Profile Main - Profile High => Same as x264enc - Profile Stereo High - Profile Multiview High => though it's not working perfectly (See bug #784321, bug #784372), these should be included imho. - Profile High Compression - Profile Low Power => This is supported by property in vaapih264enc. Do you think these should be included? - Profile Youtube => Same as x264enc It would be happy if there's someone giving opinions :)
Comment on attachment 354723 [details] Initial propose for GstVaapiEncodeH264.prs We'll need a patch for Makefile.am and meson.build why did you set the max-bframes to 1 in all the profiles? can you set multiple profiles, like "Main/High Compression"?? Otherwise, I guess there is no point to have the High Compression / Low Power profiles, since they might be parameters for all the profiles. As a matter of fact I would set tune=1 in Youtube's profile.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/issues/55.