After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783485 - st: fix "text-shadow: none" to correctly draw no shadow
st: fix "text-shadow: none" to correctly draw no shadow
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: st
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2017-06-06 15:47 UTC by Cosimo Cecchi
Modified: 2017-06-06 19:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
st: fix "text-shadow: none" to correctly draw no shadow (2.99 KB, patch)
2017-06-06 15:47 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2017-06-06 15:47:52 UTC 
See attached patch.
Comment 1 Cosimo Cecchi 2017-06-06 15:47:55 UTC 
Created attachment 353271 [details] [review]
st: fix "text-shadow: none" to correctly draw no shadow

We would incorrectly create a solid black st-shadow with no blur when
parsing in a "none" value from css.
Comment 2 Florian Müllner 2017-06-06 19:11:25 UTC 
Review of attachment 353271 [details] [review]:

I didn't test the patch, but looks correct to me (although it would be nice to avoid the explicit is_none parameter, but meh)
Comment 3 Cosimo Cecchi 2017-06-06 19:41:10 UTC 
Attachment 353271 [details] pushed as 2e1e00c - st: fix "text-shadow: none" to correctly draw no shadow