Created attachment 353189 [details] [review]
adaptivedemux: modify return value in each function

modify some return value like another demux style such as qtdemux.

Comment on attachment 353189 [details] [review]
adaptivedemux: modify return value in each function

Thanks for the patch, but why do you think this is an improvement?

(In reply to Sebastian Dröge (slomo) from comment #2)
> Comment on attachment 353189 [details] [review] [review]
> adaptivedemux: modify return value in each function
> 
> Thanks for the patch, but why do you think this is an improvement?

we already declare ret variable above line. but it's not used in the each case even though we can use it. I think that it's better to analyze modified source code. Also, I refer to another demux code such qtdemux, avidemux.

Thanks for the patch, but I think we should leave the code as it is, sorry!

It's not worth trying to make all code in GStreamer consistent in this respect, and I think where we can return TRUE/FALSE directly it makes sense to do so - it's much easier to follow the code and see what's happening in those cases.