After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783425 - css.lang: Grid properties, values, units
css.lang: Grid properties, values, units
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: Syntax files
3.22.x
Other All
: Normal enhancement
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2017-06-05 11:01 UTC by Tobias Schönberg
Modified: 2017-06-05 14:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
css.lang: Add grid properies, values and the 'fr' unit (3.84 KB, patch)
2017-06-05 11:16 UTC, Tobias Schönberg 		accepted-commit_now Details | Review

Description Tobias Schönberg 2017-06-05 11:01:24 UTC 
Grid properties are not highlighted correctly yet. Will send a patch.
Comment 1 Tobias Schönberg 2017-06-05 11:16:47 UTC 
Created attachment 353176 [details] [review]
css.lang: Add grid properies, values and the 'fr' unit

Currently grid properties and values are not highlighted. This
includes the 'fr' unit.
This commit adds the keywords to the appropriate css3 contexts and
the 'fr' unit to the dimension context.
Comment 2 Sébastien Wilmet 2017-06-05 13:11:12 UTC 
Review of attachment 353176 [details] [review]:

Looks good, thanks!
Comment 3 Tobias Schönberg 2017-06-05 14:01:16 UTC 
Thanks for the review!

Pushed here:

https://git.gnome.org/browse/gtksourceview/commit/?id=ac6338ea77fe79059e45f6f970b6ef4273a6e23b