GNOME Bugzilla – Bug 783408
Use custom popup menu for select elements
Last modified: 2017-08-05 10:19:02 UTC
Using the new WebKit API. We could use a better menu with a scrollable tree view, more consistent with other browsers.
Created attachment 353146 [details] [review] Use a custom popup menu for select elements I wrote this to check the new WebKit API. There's actually no reason why this couldn't be the default implementation in WebKit, but I think we can try it out for a while in ephy and then move it to WebKit in the next release cycle.
Created attachment 353148 [details] Screenshot
Sorry for the delay. Reviewing this is still on my TODO list. Feel free to push unreviewed if you're impatient, or wait, as you prefer.
(In reply to Michael Catanzaro from comment #3) > Sorry for the delay. Reviewing this is still on my TODO list.
Review of attachment 353146 [details] [review]: I forgot about this again, sorry. Tried the patch and it looks fine, though I'm not really sure it's much better than what we had before. I only skimmed the code. ::: embed/ephy-option-menu.c @@ +317,3 @@ + +static gboolean +ephy_option_menu_button_press_event (GtkWidget *widget, GdkEventButton *event) Two lines ::: embed/ephy-web-view.c @@ +1014,3 @@ +static gboolean +show_option_menu_cb (EphyWebView *web_view, WebKitOptionMenu *menu, GdkEvent* event, GdkRectangle *rect) It's not WebKit, declare them on three lines! @@ +1016,3 @@ +show_option_menu_cb (EphyWebView *web_view, WebKitOptionMenu *menu, GdkEvent* event, GdkRectangle *rect) +{ + g_assert(!web_view->option_menu); Missing space
Would it be too much to already move this implementation for the popups into WebKitGTK+? I have been using a patched Epiphany for almost a month now without issue, and I find this implementation more suitable for web browsing than the default one provided by WebKitGTK+.
(In reply to Adrian Perez from comment #6) > Would it be too much to already move this implementation for the popups > into WebKitGTK+? I have been using a patched Epiphany for almost a month > now without issue, and I find this implementation more suitable for web > browsing than the default one provided by WebKitGTK+. It's too late in the release cycle and only two users have tested this patch (you and me), so better land this patch in ephy and move the impl to webkit right after branching.
(In reply to Carlos Garcia Campos from comment #7) > (In reply to Adrian Perez from comment #6) > > Would it be too much to already move this implementation for the popups > > into WebKitGTK+? I have been using a patched Epiphany for almost a month > > now without issue, and I find this implementation more suitable for web > > browsing than the default one provided by WebKitGTK+. > > It's too late in the release cycle and only two users have tested this patch > (you and me), so better land this patch in ephy and move the impl to webkit > right after branching. Fair enough! Let's have it in Epiphany, and move it over later on.