GNOME Bugzilla – Bug 783404
Going in or out of fullscreen mode makes unwanted move of sidebar window to its start
Last modified: 2017-06-05 13:33:36 UTC
After activating or deactivating fullscreen mode, the sidebar window is (wrongly) moved to its start, while scroll bar stays (correctly) in its original position. The sidebar window move is unwanted and unsolicited, and it's most probably caused by GtkIconView or GtkScrolledWindow bug. Workaround this by having the sidebar sync its window with the current scroll position after a fullscreen operation, do that by just emitting a "value-changed" on the current scroll adjustment.
Created attachment 353141 [details] [review] sidebar-thumbnails: fix unwanted move to start after fullscreen After activating or deactivating fullscreen mode, the sidebar window is automatically moved to its start, while scroll bar stays in its original position. The sidebar window move is unwanted and unsolicited, and it's most probably caused by GtkIconView or GtkScrolledWindow bug. Workaround this by having the sidebar sync its window with the current scroll position after a fullscreen operation, do that by just emitting a "value-changed" on the current scroll adjustment.
Review of attachment 353141 [details] [review]: ::: shell/ev-sidebar-thumbnails.c @@ +326,3 @@ +ev_sidebar_fullscreen_cb (EvSidebarThumbnails *sidebar) +{ + /* Fixes https://bugzilla.gnome.org/show_bug.cgi?id=783404 */ Why not adding the rationale itself here? If we move to a different issue tracker the link could become broken.
Created attachment 353143 [details] [review] sidebar-thumbnails: fix unwanted move to start after fullscreen Added new version with added rationale on a comment. It's a matter of taste I guess, I prefer just to link to bugzilla to not enlarge sources too much. If gnome migrates issue tracker I hope proper link redirects are put in place, gnome sources are full of bugzilla references.
Comment on attachment 353143 [details] [review] sidebar-thumbnails: fix unwanted move to start after fullscreen Ok, thanks.
(In reply to Carlos Garcia Campos from comment #4) > Comment on attachment 353143 [details] [review] [review] > sidebar-thumbnails: fix unwanted move to start after fullscreen > > Ok, thanks. Committed as commit 2bfb8fa7c2b253 Thank you!