Created attachment 353119 [details] [review]
build: add tar-ustar to AM_INIT_AUTOMAKE

Created attachment 353120 [details] [review]
polkit: allow control over NetworkManager actions

This patch is shipped in Debian and Endless by default; since
gnome-initial-setup allows configuring connections, polkit should be
configured to allow it.

Created attachment 353121 [details] [review]
driver: update GTK text direction when locale changes

This fixes issues when switching between a RTL and LTR locale from the
initial language list.

Created attachment 353122 [details] [review]
build: add an option to specify vendor configuration file

This file will contain customization values for vendor extension
points.

Created attachment 353123 [details] [review]
gnome-initial-setup: use new vendor configuration file to skip pages

This will allow defining a custom list of skipped pages as part of
vendor image configuration.

Review of attachment 353119 [details] [review]:

sure

Review of attachment 353120 [details] [review]:

makes sense

Review of attachment 353121 [details] [review]:

wonder how we got this far without this

::: gnome-initial-setup/gis-driver.c
@@ +231,3 @@
+
+  direction = gtk_get_locale_direction ();
+  gtk_widget_set_default_direction (direction);

shouldn't this be called before rebuild_pages() since we create the new page instances there?

Review of attachment 353123 [details] [review]:

::: gnome-initial-setup/gnome-initial-setup.c
@@ -106,3 @@
   skip_pages_file = g_key_file_new ();
-  /* TODO: put the skipfile somewhere sensible */
-  if (g_key_file_load_from_file (skip_pages_file, "/tmp/skip_pages_file",

hopefully no-one is using this...

Review of attachment 353122 [details] [review]:

lgtm

Thanks, pushed with the suggested change.

Attachment 353119 [details] pushed as 5bbcf59 - build: add tar-ustar to AM_INIT_AUTOMAKE
Attachment 353120 [details] pushed as 8c9c450 - polkit: allow control over NetworkManager actions
Attachment 353121 [details] pushed as db0b19d - driver: update GTK text direction when locale changes
Attachment 353122 [details] pushed as c794f26 - build: add an option to specify vendor configuration file
Attachment 353123 [details] pushed as 8efc550 - gnome-initial-setup: use new vendor configuration file to skip pages