GNOME Bugzilla – Bug 783330
navigation: Add introspection annotations for some output parameters
Last modified: 2017-06-17 07:57:30 UTC
Created attachment 353029 [details] [review] [PATCH] navigation: Add introspection annotations for some output parameters The missing annotations prevent proper usage from introspected bindings like python.
Review of attachment 353029 [details] [review]: Thanks for this -- could you also add (optional) to the parameters which are ignored if NULL? (I don't see any that should also be (nullable), but do double check).
Created attachment 353095 [details] [review] [PATCH v2] navigation: Add introspection annotations for some output parameters changes since v1 - add (optional) where it is appropriate - add (array length) to set_commandsv
(In reply to Arun Raghavan from comment #1) > Review of attachment 353029 [details] [review] [review]: > > Thanks for this -- could you also add (optional) to the parameters which are > ignored if NULL? (I don't see any that should also be (nullable), but do > double check). The only place that seemed like it could conceivable be nullable is key from gst_navigation_event_parse_key_event. It seems more like a logic error though so I left nullable off. Seem ok?
(In reply to Scott D Phillips from comment #3) > (In reply to Arun Raghavan from comment #1) > > Review of attachment 353029 [details] [review] [review] [review]: > > > > Thanks for this -- could you also add (optional) to the parameters which are > > ignored if NULL? (I don't see any that should also be (nullable), but do > > double check). > > The only place that seemed like it could conceivable be nullable is key from > gst_navigation_event_parse_key_event. It seems more like a logic error > though so I left nullable off. Seem ok? This one's a bit awkward indeed -- I think we should either add some validation while creating the event, so we can be a bit more resilient to errors (and then we can skip the nullable). I'll do that after pushing out your fixes. Thanks!
The following fixes have been pushed: 398a6a2 navigation: Add some validation while sending key/mouse events 8d1b45d navigation: Add introspection annotations for some output parameters
Created attachment 353236 [details] [review] navigation: Add some validation while sending key/mouse events
Created attachment 353237 [details] [review] navigation: Add introspection annotations for some output parameters The missing annotations prevented proper usage from introspected bindings like python.