After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783328 - video: Compile Error in video-format.c, need to update disted orc files
video: Compile Error in video-format.c, need to update disted orc files
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal major
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-06-01 19:11 UTC by U. Artie Eoff
Modified: 2017-06-01 22:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
compilation output (189.00 KB, text/x-log)
2017-06-01 19:11 UTC, U. Artie Eoff 		  Details
configure log (138.70 KB, text/plain)
2017-06-01 19:12 UTC, U. Artie Eoff 		  Details
[PATCH] video: update orc generated files (27.73 KB, patch)
2017-06-01 20:33 UTC, Scott D Phillips 		committed Details | Review

Description U. Artie Eoff 2017-06-01 19:11:11 UTC 
Created attachment 353024 [details]
compilation output

On Ubuntu Trusty, video-format.c compilation fails (see attached build.log file).  The package liborc-0.4-dev is installed.  On Trusty liborc is version 0.4.18.  The configure.ac requires ORC_CHECK(0.4.24), however, does not cause configure to fail as it should.

The first bad commit is:

commit 103d265cf09e1ea73d5553ab11820aa89d7e2796
Author: Wim Taymans <wtaymans@redhat.com>
Date:   Thu Jun 1 17:45:41 2017 +0200

    Fix RGBA and ABGR pack/unpack on big endian cpu
    
    The pack and unpack functions for RGBA and ABGR only work for little
    endian cpus. Add variants for big endian as well.
Comment 1 U. Artie Eoff 2017-06-01 19:12:19 UTC 
Created attachment 353025 [details]
configure log
Comment 2 Scott D Phillips 2017-06-01 20:33:02 UTC 
Created attachment 353030 [details] [review]
[PATCH] video: update orc generated files

Includes updates from:

  103d265 Fix RGBA and ABGR pack/unpack on big endian cpu

---

Should we updated the dist orc files as we go, or would it be better to get configure to fail in git builds if a modern orc is missing?
Comment 3 Tim-Philipp Müller 2017-06-01 22:32:09 UTC 
commit 09af0f1fbd93e0c3c5378ce7c1f3ad7ca8f51587
Author: Scott D Phillips <scott.d.phillips@intel.com>
Date:   Thu Jun 1 13:28:42 2017 -0700

    video: update orc generated files
    
    Includes updates from:
    
      103d265 Fix RGBA and ABGR pack/unpack on big endian cpu
    
    https://bugzilla.gnome.org/show_bug.cgi?id=783328