After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783326 - [review] th/bluetooth-nap-bgo783326
[review] th/bluetooth-nap-bgo783326
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-06-01 16:51 UTC by Thomas Haller
Modified: 2017-06-07 07:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Thomas Haller 2017-06-01 16:51:26 UTC 
As follow-up to bug 783013, https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=f9b1bc16e9e691ab89caf883f33d94be72364671

I think the (public) API changes in libnm from that branch should be reverted and handled differently.

Please review.
Comment 1 Beniamino Galvani 2017-06-07 06:56:33 UTC 
> core: print the connection.type in nm_utils_log_connection_diff()

+ nm_log (level, domain, NULL, NULL, "%sconnection '%s' (%p/%s/%s%s%s and %p/%s/%s%s%s): no difference", prefix, name, connection, G_OBJECT_TYPE_NAME (connection), NM_PRINT_FMT_QUOTE_STRING (t1), diff_base, G_OBJECT_TYPE_NAME (diff_base\
), NM_PRINT_FMT_QUOTE_STRING (t2));

Please wrap such long lines.

The rest LGTM.