After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783324 - dashdemux: Nominal bitrate is estimated rather than set from selected stream
dashdemux: Nominal bitrate is estimated rather than set from selected stream
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.12.0
Other Linux
: Normal minor
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-06-01 14:50 UTC by Jonathan Miles
Modified: 2018-11-03 14:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to set fragment.bitrate in dashdemux (738 bytes, patch)
2017-06-01 14:52 UTC, Jonathan Miles 		none Details | Review
Patch to set fragment.bitrate in dashdemux (reformatted) (1.60 KB, patch)
2017-06-09 09:07 UTC, Jonathan Miles 		none Details | Review

Description Jonathan Miles 2017-06-01 14:50:31 UTC 
adaptivedemux sets GST_TAG_NOMINAL_BITRATE to stream->fragment.bitrate. If fragment.bitrate isn't set by the subclass, it will calculate a bitrate  based on fragment size and duration.

As dashdemux doesn't set fragment.bitrate, and the fragments vary in size, this means that the nominal bitrate for DASH playback varies and doesn't reflect the headline bitrate of the selected stream.
Comment 1 Jonathan Miles 2017-06-01 14:52:33 UTC 
Created attachment 353009 [details] [review]
Patch to set fragment.bitrate in dashdemux
Comment 2 Thiago Sousa Santos 2017-06-07 03:19:21 UTC 
Review of attachment 353009 [details] [review]:

Could you provide the patch in git format-patch format, please? Make sure your name and email are correct in got config so that it shows in the patch headers.

Thanks!
Comment 3 Jonathan Miles 2017-06-09 09:07:13 UTC 
Created attachment 353442 [details] [review]
Patch to set fragment.bitrate in dashdemux (reformatted)
Comment 4 GStreamer system administrator 2018-11-03 14:08:51 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/561.