After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783321 - Don't use Tweener in PreviewNavControls
Don't use Tweener in PreviewNavControls
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
3.25.x
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
: 781230 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2017-06-01 13:08 UTC by Debarshi Ray
Modified: 2017-09-24 12:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use GtkRevealers for faders instead of Tweener (9.71 KB, patch)
2017-06-01 13:13 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2017-06-01 13:08:10 UTC 
Tweener was already replaced with GtkRevealer in commit de8b10a7bb1b9e1c633437588cfe51b79a66cfbe but was reverted soon after (commit 1b852e7640d1a3cc1e0571361dc0c96b4534e850). I don't know why, but GtkRevealer seems to work just fine, and it's better to stick to stock GTK+ API.
Comment 1 Debarshi Ray 2017-06-01 13:13:43 UTC 
Created attachment 353006 [details] [review]
Use GtkRevealers for faders instead of Tweener

This is based on top of the patches in bug 782685.
Comment 2 Cosimo Cecchi 2017-06-01 17:52:36 UTC 
Review of attachment 353006 [details] [review]:

Nice!
Comment 3 Debarshi Ray 2017-06-02 14:40:02 UTC 
Comment on attachment 353006 [details] [review]
Use GtkRevealers for faders instead of Tweener

Thanks, Cosimo. Pushed to master.
Comment 4 Debarshi Ray 2017-09-24 12:34:28 UTC 
*** Bug 781230 has been marked as a duplicate of this bug. ***