After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783299 - Don't show "Home" button if home page is set to "blank page"
Don't show "Home" button if home page is set to "blank page"
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Interface
3.24.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-31 19:33 UTC by Stephen
Modified: 2017-10-27 04:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
header-bar: do not show home button if home page is set to blank page (987 bytes, patch)
2017-10-26 03:58 UTC, Mal
committed Details | Review

Description Stephen 2017-05-31 19:33:45 UTC
It would make sense to not show the home button if the home page is set to "blank page", since the button is not likely to be used in that case, and the user is likely to have "blank page" set for the purpose of new tabs/windows only.

See https://bugzilla.gnome.org/show_bug.cgi?id=783288 for related discussion.
Comment 1 Mal 2017-10-26 03:58:10 UTC
Created attachment 362302 [details] [review]
header-bar: do not show home button if home page is set  to blank page
Comment 2 Michael Catanzaro 2017-10-26 12:15:38 UTC
Review of attachment 362302 [details] [review]:

Thanks. It's rare to see a patch from a new contributor where I can't find a single problem, but you did it. ;)
Comment 3 Michael Catanzaro 2017-10-27 04:49:59 UTC
Aaand you made it in just before release! This is in 3.26.2.