Created attachment 352917 [details] [review]
rtpptdemux: uniquify stream id.

This is just a proposal, for now when using rtspsrc we sometimes (undeterministically) end up with the same stream id for both streams, as a "single part", ie with no "/".

With this patch at least the part after the "/" is now deterministic, though potentially not that unique.

Curious if anyone has a better idea ?

In that specific case, it could make sense to hash the content of the first buffer maybe ?

Created attachment 352919 [details] [review]
rtpptdemux: uniquify stream id.

By appending ("/%d", payload_type) to the upstream stream id.

Created attachment 352920 [details] [review]
rtpptdemux: uniquify stream id.

By appending ("/%s", payload_hash) to the upstream stream id.

Alternate proposal, it is both deterministic and way more likely to be unique

Why a hash? ptdemux is demuxing based on the payload type, so use that :)

Created attachment 352960 [details] [review]
rtpptdemux: uniquify stream id.

By appending ("/%s", payload_hash) to the upstream stream id.

Review of attachment 352960 [details] [review]:

::: gst/rtpmanager/gstrtpptdemux.c
@@ +404,3 @@
+          g_compute_checksum_for_data (G_CHECKSUM_MD5,
+              gst_rtp_buffer_get_payload (&rtp),
+              gst_rtp_buffer_get_payload_len (&rtp)));

Why not:
stream_id = gst_pad_create_stream_id_printf(srcpad, rtpdemux, "%u", pt)?

Closing, new proposal at https://bugzilla.gnome.org/show_bug.cgi?id=783307

Review of attachment 352960 [details] [review]:

Obsolete

Not really, rtpptdemux should set unique stream ids in any case.

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/375.