Bug 783250 – segfault on "Import From Application..." when no data-import plugin enabled

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 783250 - segfault on "Import From Application..." when no data-import plugin enabled


Summary:	segfault on "Import From Application..." when no data-import plugin enabled


Status:	RESOLVED FIXED

Product:	shotwell
Classification:	Other
Component:	general
Version:	0.26.x
Hardware:	Other Linux

Importance:	Normal critical
Target Milestone:	0.28
Assigned To:	Shotwell Maintainers
QA Contact:	Shotwell Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2017-05-30 21:37 UTC by Dominique Leuenberger
Modified:	2017-06-01 16:43 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Fix crash when no import plugin is enabled (1.14 KB, patch) 2017-06-01 16:43 UTC, Jens Georg	committed	Details \| Review

Description Dominique Leuenberger 2017-05-30 21:37:50 UTC

## Overview

Shotwell crashes when "File -> Import From Application..." is selected and the Data Import plugin has been disabled.

## Steps to reproduce

1.  Open Shotwell
2.  Go to "Edit -> Preferences -> Plugins" and disable the plugin under Data Imports (it’s called F-Spot).
3.  Click "File -> Import From Application...".

## Actual result

Spotwell crashes (command line output attached).

## Expected result

Some explanation that an active data-import plugin is needed for importing, or at least an error message.

Comment 1 Dominique Leuenberger 2017-05-30 21:41:24 UTC

Core was generated by `shotwell'.
Program terminated with signal SIGSEGV, Segmentation fault.

+ Trace 237529

#0 gtk_widget_get_css_node
at gtkwidget.c line 16539
#0 gtk_widget_get_css_node
at gtkwidget.c line 16539
#1 gtk_header_bar_reorder_css_node
at gtkheaderbar.c line 562
#2 gtk_header_bar_pack
at gtkheaderbar.c line 1651
#3 gtk_header_bar_pack_end
at gtkheaderbar.c line 2193
#4 data_imports_ui_data_imports_dialog_construct
at /home/jens/Source/shotwell/src/data_imports/DataImportsUI.vala line 298
#5 data_imports_ui_data_imports_dialog_new
at /home/jens/Source/shotwell/src/data_imports/DataImportsUI.vala line 210
#6 data_imports_ui_data_imports_dialog_get_or_create_instance
at /home/jens/Source/shotwell/src/data_imports/DataImportsUI.vala line 322
#7 library_window_on_external_library_import
at /home/jens/Source/shotwell/src/library/LibraryWindow.vala line 533
#8 _library_window_on_external_library_import_gsimple_action_activate_callback
at /home/jens/Source/shotwell/src/library/LibraryWindow.vala line 271
#9 g_closure_invoke
#10 0x00007fe61c27632e in
#11 g_signal_emit_valist
#12 g_signal_emit
#13 g_simple_action_activate
at gsimpleaction.c line 225
#14 gtk_action_muxer_activate_action
at gtkactionmuxer.c line 412
#15 gtk_action_muxer_activate_action
at gtkactionmuxer.c line 414
#16 gtk_menu_tracker_item_activated
at gtkmenutrackeritem.c line 799
#17 g_closure_invoke
#18 0x00007fe61c27632e in
#19 g_signal_emit_valist
#20 g_signal_emit
#21 gtk_widget_activate
at gtkwidget.c line 7757
#22 gtk_menu_shell_activate_item
at gtkmenushell.c line 1375
#23 gtk_menu_shell_button_release
at gtkmenushell.c line 791
#24 _gtk_marshal_BOOLEAN__BOXEDv
at gtkmarshalers.c line 143
#25 0x00007fe61c262d06 in
#26 g_signal_emit_valist
#27 g_signal_emit
#28 gtk_widget_event_internal
at gtkwidget.c line 7724
#29 gtk_widget_event
at gtkwidget.c line 7294
#30 propagate_event_up
at gtkmain.c line 2568
#31 propagate_event
at gtkmain.c line 2670
#32 gtk_main_do_event
at gtkmain.c line 1901
#33 _gdk_event_emit
at gdkevents.c line 73
#34 gdk_event_source_dispatch
at gdkeventsource.c line 121
#35 g_main_dispatch
at gmain.c line 3234
#36 g_main_context_dispatch
at gmain.c line 3899
#37 g_main_context_iterate
at gmain.c line 3972
#38 g_main_context_iteration
at gmain.c line 4033
#39 g_application_run
at gapplication.c line 2381
#40 application_start
at /home/jens/Source/shotwell/src/Application.vala line 182
#41 library_exec
at /home/jens/Source/shotwell/src/main.vala line 196
#42 _vala_main
at /home/jens/Source/shotwell/src/main.vala line 427
#43 main
at /home/jens/Source/shotwell/src/main.vala line 316

Comment 2 Jens Georg 2017-06-01 16:43:09 UTC

Created attachment 353022 [details] [review]
Fix crash when no import plugin is enabled

Comment 3 Jens Georg 2017-06-01 16:43:34 UTC

Attachment 353022 [details] pushed as 153f780 - Fix crash when no import plugin is enabled