Created attachment 352839 [details] [review]
Add tag toilets to map bubbles

Created attachment 352840 [details] [review]
osmEditDialog: Add edit/add of toilets

These patches follow on from the religion tag patches (bug 783225).

Review of attachment 352839 [details] [review]:

::: src/translations.js
@@ +387,3 @@
 }
+
+function translateToilets(string) {

I think this should probably be named something like "translateYesNo", as it's not really toilet-specific ☺

Review of attachment 352840 [details] [review]:

LGTM

Actually, we might want to add a boolean edit widget for "yes/no" things like this, i.e. rendered as checkbox. The tricky part is that the OSM tag can contain arbitrary data (which is kinda handle by the current combo boxes by showing an empty value and letting the user set just the pre-defined values).

Thanks for the patches, btw!

And I think ultimately we would like to redesign the map bubbles to use less verbose text labels, showing i.e. a toilet symbol for things like this and for accessability information.

+1 for showing icons for toilets etc.

Created attachment 352907 [details] [review]
Add tag toilets to map bubbles

Review of attachment 352907 [details] [review]:

LGTM

Attachment 352840 [details] pushed as f89256a - osmEditDialog: Add edit/add of toilets
Attachment 352907 [details] pushed as a7116e2 - Add tag toilets to map bubbles