After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783217 - Use a symbolic icon for appmenu if found
Use a symbolic icon for appmenu if found
Status: RESOLVED OBSOLETE
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2017-05-29 21:31 UTC by Bilal Elmoussaoui
Modified: 2018-05-02 18:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Bilal Elmoussaoui 2017-05-29 21:31:37 UTC 
For now, if you disable "Show Application Menu" on Gnome Tweak Tool (Top Bar). The icon that's going to be used for the application menu is the icon name of the current application. 

Almost every application that follows Gnome Human Interface design guidelines uses symbolic icons on the HeaderBar. The icon used looks like an alien. Can you instead check whether a symbolic icon is included by the application if so use it otherwise fallback to the icon name.


Also, using process-stop-symbolic as an icon name if the original icon is not found is not the best choice. Maybe asking the gnome design team to provide an icon that fits more for this context ?

See:
https://git.gnome.org/browse/gtk+/tree/gtk/gtkheaderbar.c#n379
https://git.gnome.org/browse/gtk+/tree/gtk/gtkheaderbar.c#n382


Thanks
Comment 1 Matthias Clasen 2017-06-28 22:05:17 UTC 
This is fallback code that is not meant to be triggered, under normal circumstances, so I don't really want to make it much more complicated.
That being said, if you can get a better icon, or provide a patch to determine the symbolic icon, I will happily review and apply it.
Comment 2 Daniel Boles 2017-10-09 11:25:34 UTC 
(In reply to Bilal Elmoussaoui from comment #0)
> Almost every application that follows Gnome Human Interface design
> guidelines uses symbolic icons on the HeaderBar. The icon used looks like an
> alien. Can you instead check whether a symbolic icon is included by the
> application if so use it otherwise fallback to the icon name.

I wasn't aware that it was GTK+'s job to enforce the HIG on people. It's not confined to GNOME and GNOME-style applications.

If you really want a symbolic icon there, you can probably force it in your CSS using -gtk-icon-style.


(In reply to Bilal Elmoussaoui from comment #0)
> Also, using process-stop-symbolic as an icon name if the original icon is
> not found is not the best choice. Maybe asking the gnome design team to
> provide an icon that fits more for this context ?

That was fixed in Bug 784624.
Comment 3 GNOME Infrastructure Team 2018-05-02 18:32:36 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gtk/issues/829.