Created attachment 352809 [details] [review]
build: Drop check for gjs-console

Nowadays all javascript code is run via small C-wrappers ...

Created attachment 352810 [details] [review]
build: Always install xdg-desktop-portal metadata

The build target accidentally ended up in a network manager conditional,
though the portal doesn't depend on NM in any way.

Created attachment 352811 [details] [review]
build: Stop building a separate libgnome-shell-base

The static library was split out to avoid duplicate compilation
of mutter-independent libgnome-shell sources when we had a
wayland/non-wayland split. With the separate libmutter-wayland
library long gone, there's no reason to make the build more
complicated than it needs to be, so fold libgnome-shell-base
back into the regular libgnome-shell.

Created attachment 352812 [details] [review]
build: Drop obsolete pkg-config check

The check belongs to the test-recorder executable that was dropped
in commit d52c95a15f5e.

Created attachment 352813 [details] [review]
tests: Adjust test runner

The script currently assumes that srcdir is relative to builddir,
which is not the case for build directories outside the source tree
like the one used by jhbuild.
While we could get fancy and prepend the builddir if srcdir is relative,
there's nothing wrong with a relative path as we cd into the builddir
before evaluating srcdir.

Review of attachment 352809 [details] [review]:

++

Review of attachment 352810 [details] [review]:

why not do the same for the .desktop and .service files too and drop the whole conditional?

Review of attachment 352812 [details] [review]:

ok

Review of attachment 352813 [details] [review]:

sure

Review of attachment 352811 [details] [review]:

looks good

(In reply to Rui Matos from comment #7)
> why not do the same for the .desktop and .service files too and drop the
> whole conditional?

Those belong to the helper that pops up a login window when connecting to a network that's behind a portal, so they are indeed tied to network manager. I don't think it would actually hurt installing them anyway, but omitting them makes some sense.

The same cannot be said about the xdg-desktop-portal, which is essentially a DBus interface description to allow flatpak to use system modal dialogs when asking for app permissions.

Review of attachment 352810 [details] [review]:

aha, of course, I thought xdg-desktop-portal was a standard for network portals

Attachment 352809 [details] pushed as e7bf238 - build: Drop check for gjs-console
Attachment 352810 [details] pushed as 60c00f0 - build: Always install xdg-desktop-portal metadata
Attachment 352811 [details] pushed as 31a4705 - build: Stop building a separate libgnome-shell-base
Attachment 352812 [details] pushed as 4bada06 - build: Drop obsolete pkg-config check
Attachment 352813 [details] pushed as 73cffb3 - tests: Adjust test runner