GNOME Bugzilla – Bug 783185
Show religion tag
Last modified: 2017-05-30 20:09:03 UTC
Created attachment 352752 [details] [review] Show religion tag OpenStreetMap has a 'religion' tag [1] which is commonly used with amenity=place_of_worship, amenity=school or shop=religion. Attached patch makes GNOME Maps show this tag and makes it editable. I initially worked on also supporting the denomination tag, but that turned out to be a little more complex (they should be linked in the edit view, and there's a lot of denominations that we'd want translations for). I figure this could be added later. [1] https://wiki.openstreetmap.org/wiki/Key:religion
Review of attachment 352752 [details] [review]: I think the code looks good. However, I think I'd prefer the osmEditDialog stuff in its own commit, as that part is de-coupled from the viewing part (which used Overpass), the OSM edit dialog is basically just a "window" into parts of the tags of the OSM object (which are all fetched internally behind the scenes when editing).
Thanks for the patch!
Created attachment 352827 [details] [review] Add tag religion to map bubbles
Created attachment 352828 [details] [review] osmEditDialog: Add edit/add of religion
Review of attachment 352827 [details] [review]: LGTM
Review of attachment 352828 [details] [review]: LGTM
Attachment 352827 [details] pushed as e179346 - Add tag religion to map bubbles Attachment 352828 [details] pushed as 15bc1ce - osmEditDialog: Add edit/add of religion