GNOME Bugzilla – Bug 783149
About dialog gives gnome-shell version but not gnome-tweak-tool version
Last modified: 2017-06-28 19:05:02 UTC
The About Dialog for Tweak Tool shows the gnome-shell version number but it should display the gnome-tweak-tool version number.
Created attachment 352731 [details] [review] about: Mention Tweak Tool version
Created attachment 352732 [details] [review] about: Don't show (user mode) next to GNOME Shell version Because it is the default mode and not useful information. Still show other modes like (classic mode). And adjust strings to help translators.
Created attachment 352733 [details] [review] about: Mention GTK+ version This could be useful info for theming. Also GNOME versions and GTK+ versions are no longer aligned.
Created attachment 352734 [details] [review] about: Use correct homepage link
Created attachment 352735 [details] [review] configure.ac: Use correct bug report link
Created attachment 352736 [details] [review] about: Mention GTK+ version This could be useful info for theming. Also GNOME versions and GTK+ versions are no longer aligned.
(In reply to Jeremy Bicha from comment #2) > Created attachment 352732 [details] [review] [review] > about: Don't show (user mode) next to GNOME Shell version > > Because it is the default mode and not useful information. > Still show other modes like (classic mode). > > And adjust strings to help translators. I might be interpreting it wrong, but it looks like the translator can’t change the order of “%s mode”, which many languages require. For example, in Polish I need “tryb %s”, while “%s tryb” is very, very wrong.
Created attachment 352740 [details] [review] about: Don't show (user mode) next to GNOME Shell version Piotr, thanks for the feedback. I think this should work better. I left the parentheses inside the translatable string. Is that a good idea?
Yes, it should be fine now. In general, splitting strings is rarely a good idea: https://wiki.gnome.org/TranslationProject/DevGuidelines/Never%20split%20sentences
Review of attachment 352731 [details] [review]: ::: gtweak/app.py @@ +94,3 @@ def about_cb(self, action, parameter): aboutdialog = Gtk.AboutDialog() + aboutdialog.set_program_name(aboutdialog.get_program_name() + " %s" % VERSION) there's a gtk_about_dialog_set_version() api for this purpose, please use that
Review of attachment 352734 [details] [review]: ++
Review of attachment 352735 [details] [review]: sure
Review of attachment 352736 [details] [review]: looks fine but please mind the comment below before pushing ::: gtweak/app.py @@ +105,3 @@ about_comment = _("GNOME Shell is not running.") + about_comment += "\n " + _("GTK+") + " %d.%d.%d" % (Gtk.get_major_version(), Gtk.get_minor_version(), Gtk.get_micro_version()) drop the space after \n since it's not needed and this way the string doesn't look completely centered
Review of attachment 352740 [details] [review]: looks fine otherwise, thanks for the patches ::: gtweak/app.py @@ +104,2 @@ else: + about_comment = _("GNOME Shell is not running.") the period at the end looks odd, I think we shouldn't have it here
(In reply to Rui Matos from comment #10) > Review of attachment 352731 [details] [review] [review]: > > ::: gtweak/app.py > @@ +94,3 @@ > def about_cb(self, action, parameter): > aboutdialog = Gtk.AboutDialog() > + aboutdialog.set_program_name(aboutdialog.get_program_name() + " %s" > % VERSION) > > there's a gtk_about_dialog_set_version() api for this purpose, please use > that When I did that, the version number showed up on its own line which I thought looked bad.
Attachment 352736 [details] pushed as 3a54942 - about: Mention GTK+ version
Review of attachment 352731 [details] [review]: ok, so let's go with this
Attachment 352731 [details] pushed as 5543a2b - about: Mention Tweak Tool version
*** Bug 784303 has been marked as a duplicate of this bug. ***