GNOME Bugzilla – Bug 783121
Allow ctrl+= as a zoom-in accelerator
Last modified: 2017-05-26 10:14:25 UTC
On many keyboard layouts the shift modifier is needed to access the '+' key. It's a tad more convenient to be able to use an accelerator without pressing shift. Since '=' usually shares the key with '+', that's the most common fallback. Maps already allows '+' and '=' for zooming in, but not for the ctrl variants. Since the ctrl-less variants are eaten up by the GtkEntry after start-up, unless someone explicitly changes the focus, having ctrl+= will make Maps slightly more keyboard friendly.
Created attachment 352635 [details] [review] mainWindow: Add <Primary>equal to the list of zoom-in accelerators
Review of attachment 352635 [details] [review]: LGTM
Thanks for the patch! Works great! Actually, using plain +/= should work, but currently those end up in the search box (I think we have some logic for that, but maybe in has regressed), I guess I'll file an additional bug about that, I guess.
Attachment 352635 [details] pushed as 201a1af - mainWindow: Add <Primary>equal to the list of zoom-in accelerators
(In reply to Marcus Lundblad from comment #3) > Actually, using plain +/= should work, but currently those end up in the > search box (I think we have some logic for that, but maybe in has > regressed), I guess I'll file an additional bug about that, I guess. When the main window is shown after start-up the GtkEntry has the keyboard focus. That's why the '+' and '=' keys get eaten up by it (due to commit 80f9b0f72d95256db42149afc148dbe18a55b4e5, I think).
Thanks for the review!