After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783058 - can't go back after searching "Romanian" or "Hindi"
can't go back after searching "Romanian" or "Hindi"
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Keyboard
3.24.x
Other Linux
: Normal normal
: ---
Assigned To: Rui Matos
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-24 20:56 UTC by jean-baptiste
Modified: 2017-05-30 16:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
region: Make the input source chooser back button activate on click (2.05 KB, patch)
2017-05-30 16:29 UTC, Rui Matos
committed Details | Review
region: Don't return the input chooser dialog if nothing is selected (1.35 KB, patch)
2017-05-30 16:29 UTC, Rui Matos
committed Details | Review
region: Avoid starting with a gap at the bottom of the input chooser (1.09 KB, patch)
2017-05-30 16:30 UTC, Rui Matos
committed Details | Review

Description jean-baptiste 2017-05-24 20:56:21 UTC
hi,

I use gnome-control-center 3.24.2 and tested f26.
When I search "Roumain" (Romanian in French), Gnome finds out "Romanian", but I can't get backward. It also does it for Hindi. I assume it may bug in other languages.

main issue :
* we should be able to use the "back" button

minor issue :
* Romanian should be translated Roumain. Where can I see the translation ? (I couldn't figure out where it could be in http://l10n.gnome.org/)

Here is the video: https://jibecfed.fedorapeople.org/partage/Capture%20d'%c3%a9cran%20vid%c3%a9o%20de%2024-05-2017%2022:40:25.webm
Comment 1 Rui Matos 2017-05-25 09:14:03 UTC
(In reply to jean-baptiste from comment #0)
> main issue :
> * we should be able to use the "back" button

just clear the search term

> minor issue :
> * Romanian should be translated Roumain. Where can I see the translation ?
> (I couldn't figure out where it could be in http://l10n.gnome.org/)

Translations are provided by the iso-codes package, see https://pkg-isocodes.alioth.debian.org/
Comment 2 jean-baptiste 2017-05-26 05:44:58 UTC
Well. Ok, indeed, thanks for both answers. Nobody likes to get a "NOTABUG" ;)

I find the search process quite confusing... I'll send a feature request instead of a bug report. Should I open it this project?


By the way, if I open the window, without searching anything and double click on "Anglais (Royaume Unis)", it closes the windows.
https://jibecfed.fedorapeople.org/partage/Capture%20d'%c3%a9cran%20vid%c3%a9o%20de%2026-05-2017%2007:40:23.webm

it works with both Fedora 25 and F26. Can you also see this?
Comment 3 Rui Matos 2017-05-30 16:28:16 UTC
(In reply to jean-baptiste from comment #2)
> By the way, if I open the window, without searching anything and double
> click on "Anglais (Royaume Unis)", it closes the windows.
> https://jibecfed.fedorapeople.org/partage/
> Capture%20d'%c3%a9cran%20vid%c3%a9o%20de%2026-05-2017%2007:40:23.webm
> 
> it works with both Fedora 25 and F26. Can you also see this?

Yes, seems like a bug. I'll push a few patches that make the dialog behave a bit better for now.
Comment 4 Rui Matos 2017-05-30 16:29:53 UTC
Created attachment 352886 [details] [review]
region: Make the input source chooser back button activate on click

We lost this behavior with commit
3b14056a01b2dd16880e9f936de8be3cf13cc96f to fix keyboard navigation
but we can add it back by handling button events ourselves.
Comment 5 Rui Matos 2017-05-30 16:29:59 UTC
Created attachment 352887 [details] [review]
region: Don't return the input chooser dialog if nothing is selected

In some cases we end up getting an input source row activated without
it being selected. This seems like a GtkListBox bug but we can easily
avoid it.
Comment 6 Rui Matos 2017-05-30 16:30:07 UTC
Created attachment 352888 [details] [review]
region: Avoid starting with a gap at the bottom of the input chooser

We can simply let the natural size request determine the dialog's
height.
Comment 7 Rui Matos 2017-05-30 16:33:05 UTC
Attachment 352886 [details] pushed as 6e4b4e9 - region: Make the input source chooser back button activate on click
Attachment 352887 [details] pushed as c99f6b5 - region: Don't return the input chooser dialog if nothing is selected
Attachment 352888 [details] pushed as 4bb33fd - region: Avoid starting with a gap at the bottom of the input chooser