After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783043 - Critical on startup due to Debian's Esperanto locale
Critical on startup due to Debian's Esperanto locale
Status: RESOLVED FIXED
Product: gnome-initial-setup
Classification: Applications
Component: general
3.24.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Initial Setup maintainer(s)
GNOME Initial Setup maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-05-24 12:19 UTC by Michael Catanzaro
Modified: 2017-05-24 17:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
language: Fix critical when creating widget for Esperanto (3.29 KB, patch)
2017-05-24 12:35 UTC, Michael Catanzaro 		committed Details | Review

Description Michael Catanzaro 2017-05-24 12:19:45 UTC 
Debian has a bunch of custom locales not present in other distros, including an Esperanto locale with no country code at all: "eo.UTF-8" and also plain "eo" (non-UTF-8). cc-language-chooser isn't quite prepared to handle languages without a country code. It actually looks just fine currently -- the country name is just missing from the list box, which seems like the right thing to do -- but emits a critical warning. We should probably avoid the critical.
Comment 1 Michael Catanzaro 2017-05-24 12:35:44 UTC 
Created attachment 352491 [details] [review]
language: Fix critical when creating widget for Esperanto

It has no country code, and the language chooser is unprepared to
handle this case. gnome_parse_locale can legitimately return success
with a NULL country and we should handle that. Note this locale exists
only in Debian, which has a bunch of glibc patches to add new locales,
but apparently Debian is big and we should probably make it work
properly.
Comment 2 Rui Matos 2017-05-24 12:57:27 UTC 
Review of attachment 352491 [details] [review]:

looks fine, thanks
Comment 3 Michael Catanzaro 2017-05-24 17:05:12 UTC 
Attachment 352491 [details] pushed as 75cb20b - language: Fix critical when creating widget for Esperanto