GNOME Bugzilla – Bug 783042
-Wformat warnings triggered by use of gtk_dialog_new_with_buttons
Last modified: 2017-05-24 17:05:30 UTC
I see a couple -Wformat warnings when compiling gnome-initial-setup: gis-privacy-page.c: In function 'activate_link': gis-privacy-page.c:255:41: warning: not enough variable arguments to fit a sentinel [-Wformat=] NULL); ^ I think gtk_dialog_new_with_buttons should be called with two trailing NULLs when there are no buttons to add: the first NULL for the button text, and the second NULL to end the va_list. That avoids these warnings.
Created attachment 352489 [details] [review] goa: Fix insufficient function arguments warning
Created attachment 352490 [details] [review] privacy: Fix insufficient function arguments warning
Review of attachment 352490 [details] [review]: looks fine
Review of attachment 352489 [details] [review]: sure. thanks
Attachment 352489 [details] pushed as 60fd1cd - goa: Fix insufficient function arguments warning Attachment 352490 [details] pushed as fced05b - privacy: Fix insufficient function arguments warning