After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783008 - Add error-message, error-for, details, and details-for relation types
Add error-message, error-for, details, and details-for relation types
Status: RESOLVED FIXED
Product: at-spi
Classification: Platform
Component: at-spi2-atk
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Joanmarie Diggs (IRC: joanie)
At-spi maintainer(s)
Depends on: 781587 782999
Blocks:
 
 
Reported: 2017-05-23 17:07 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2017-05-26 09:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (1.20 KB, patch)
2017-05-23 17:09 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2017-05-23 17:07:25 UTC
ARIA 1.1 introduced two new properties which are to be mapped on our platform via accessible relations, namely:

* error-message
* error-for
* details
* details-for

We need to add these to ATK (being done in bug 781587) and at-spi2-core (being done in bug 782999). Once they are in both, we need to map the former to the latter in at-spi2-atk (this bug).
Comment 1 Joanmarie Diggs (IRC: joanie) 2017-05-23 17:09:38 UTC
Created attachment 352440 [details] [review]
proposed patch

Please review. Thanks!
Comment 2 Mike Gorse 2017-05-26 02:08:33 UTC
Comment on attachment 352440 [details] [review]
proposed patch

Lgtm. I've bumped the at-spi2-core version. We should bump the at-spi2-core version requirement again.
Comment 3 Joanmarie Diggs (IRC: joanie) 2017-05-26 09:35:12 UTC
Comment on attachment 352440 [details] [review]
proposed patch

(In reply to Mike Gorse from comment #2)
> Comment on attachment 352440 [details] [review] [review]
> proposed patch
> 
> Lgtm. I've bumped the at-spi2-core version. We should bump the at-spi2-core
> version requirement again.

Thanks for the review. Patch committed, with the version bump included: https://git.gnome.org/browse/at-spi2-atk/commit/?id=6b2651f