After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783007 - Binaries are linked against GConf when `--disable-gconf` was passed
Binaries are linked against GConf when `--disable-gconf` was passed
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-23 17:02 UTC by Marvin Schmidt
Modified: 2017-06-26 15:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
remove old GCONFTOOL_CMD and GCONF_SANITY_CHECK defines (1.04 KB, patch)
2017-05-23 17:02 UTC, Marvin Schmidt 		committed Details | Review
fix configure logic for gconf switch (1.69 KB, patch)
2017-05-23 17:03 UTC, Marvin Schmidt 		committed Details | Review

Description Marvin Schmidt 2017-05-23 17:02:26 UTC 
Created attachment 352438 [details] [review]
remove old GCONFTOOL_CMD and GCONF_SANITY_CHECK defines

Due to wrong logic in the configure script some binaries (gnome-session-binary, gnome-session-quit) are linked against libgconf when it's present although `--disable-gconf` was passed. Attached is a proposed fix for this. The other patch just cleans up some old left-overs

Cheers,
Marvin
Comment 1 Marvin Schmidt 2017-05-23 17:03:21 UTC 
Created attachment 352439 [details] [review]
fix configure logic for gconf switch
Comment 2 Ray Strode [halfline] 2017-05-23 20:15:33 UTC 
Review of attachment 352438 [details] [review]:

thanks.
Comment 3 Ray Strode [halfline] 2017-05-23 20:16:14 UTC 
Review of attachment 352439 [details] [review]:

sure
Comment 4 Marvin Schmidt 2017-06-25 10:33:02 UTC 
Just a friendly ping, these patches should be good to go, no?