After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783000 - tests: videoscale: Fix build warning error
tests: videoscale: Fix build warning error
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-23 13:56 UTC by Seungha Yang
Modified: 2017-10-27 12:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tests: videoscale: Fix build warning error (3.80 KB, patch)
2017-05-23 13:57 UTC, Seungha Yang 		none Details | Review

Description Seungha Yang 2017-05-23 13:56:41 UTC 
elements/videoscale.c:1013:7: error: "VSCALE_TEST_GROUP" is not defined [-Werror=undef]
 #elif VSCALE_TEST_GROUP == 1
Comment 1 Seungha Yang 2017-05-23 13:57:32 UTC 
Created attachment 352428 [details] [review]
tests: videoscale: Fix build warning error
Comment 2 Tim-Philipp Müller 2017-05-24 08:53:45 UTC 
How are you building this?

There are clearly -DVSCALE_TEST_GROUP=N in Makefile.am and meson.build, no?
Comment 3 Seungha Yang 2017-05-25 03:41:12 UTC 
(In reply to Tim-Philipp Müller from comment #2)
> How are you building this?
> 
> There are clearly -DVSCALE_TEST_GROUP=N in Makefile.am and meson.build, no?

At root, I did "make check" to run all unit tests
Comment 4 Tim-Philipp Müller 2017-05-25 07:42:53 UTC 
Ok, could you please investigate why this happens then?

Clearly it's not supposed to happen and it should be defined as far as I can tell from the Makefile.am. And it is defined if I do this.

The patch just works around something that shouldn't be happening in the first place :)
Comment 5 Seungha Yang 2017-05-25 08:13:42 UTC 
It's clear that VSCALE_TEST_GROUP is defined for videoscale-{1 ~ 6} but not for *videoscale*
Comment 6 Edward Hervey 2017-10-27 12:22:27 UTC 
Closing this for now. Seems to be specific to a different way of building/running tests.