Bug 782998 – Crash under on_object_list_got() provider/biji-memo-provider.c:293

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 782998 - Crash under on_object_list_got() provider/biji-memo-provider.c:293


Summary:	Crash under on_object_list_got() provider/biji-memo-provider.c:293


Status:	RESOLVED FIXED

Product:	bijiben
Classification:	Applications
Component:	Providers
Version:	3.21.x
Hardware:	Other Linux

Importance:	Normal critical
Target Milestone:	---
Assigned To:	Bijiben maintainer(s)
QA Contact:	Bijiben maintainer(s)

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2017-05-23 13:17 UTC by Milan Crha
Modified:	2017-06-12 08:07 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
proposed patch (404 bytes, patch) 2017-05-23 13:23 UTC, Milan Crha	accepted-commit_now	Details \| Review
memo-provider: Crash opening memo (932 bytes, patch) 2017-06-11 18:59 UTC, Isaque Galdino	committed	Details \| Review

Description Milan Crha 2017-05-23 13:17:20 UTC

This is with git master at commit 5ff688e. Opening bijiben leads to a crash with the below backtrace. It doesn't even map UI, the memo is in the memo list available from the beginning.

+ Trace 237504

Thread 1 (Thread 0x7f68b1a66440 (LWP 18716))

#0 waitpid
#1 do_system
#2 bugbuddy_segv_handle
at gnome-segvhanlder.c line 180
#3 <signal handler called>
#4 time_val_from_icaltime
at provider/biji-memo-provider.c line 81
#5 on_object_list_got
at provider/biji-memo-provider.c line 293
#6 g_simple_async_result_complete
at gsimpleasyncresult.c line 801
#7 complete_in_idle_cb_for_thread
at gsimpleasyncresult.c line 872
#8 g_idle_dispatch
at gmain.c line 5545
#9 g_main_dispatch
at gmain.c line 3203
#10 g_main_context_dispatch
at gmain.c line 3856
#11 g_main_context_iterate
at gmain.c line 3929
#12 g_main_context_iteration
at gmain.c line 3990
#13 g_application_run
at gapplication.c line 2381
#14 main
at bjb-main.c line 37

Comment 1 Milan Crha 2017-05-23 13:23:27 UTC

Created attachment 352424 [details] [review]
proposed patch

Trivial fix, do not dereference NULL.

Comment 2 Isaque Galdino 2017-05-24 02:18:00 UTC

Review of attachment 352424 [details] [review]:

Hi, thanks for your patch.

When I tried to apply this to master, I got: "fatal: empty ident name (for <>) not allowed". The, checking your patch, it seems it's missing the headers, like this:
From 9d9e82ca2b545e318a7eed68428cb1d8a9b778e5 Mon Sep 17 00:00:00 2001
From: it should be you <your-email@your-domain>
Date: Sun, 21 Feb 2016 21:40:58 +0000
Subject: [PATCH] memo-provider: title

Please fix that and send me again, I'll be glad to commit it. Thanks.

Comment 3 Milan Crha 2017-05-24 15:47:51 UTC

(In reply to Isaque Galdino from comment #2)
> When I tried to apply this to master, I got: "fatal: empty ident name (for
> <>) not allowed".

That's correct, it's a pure patch, not git-formatted patch. It's applied by:
   $ patch -p1 <patch.patch

Comment 4 Isaque Galdino 2017-06-11 18:59:49 UTC

Created attachment 353576 [details] [review]
memo-provider: Crash opening memo

Application is crashing when trying to open a memo from the memo list.

Code is not checking for null when processing start, last modified and
created dates.

This patch fixes that.

Comment 5 Isaque Galdino 2017-06-11 19:01:01 UTC

Review of attachment 353576 [details] [review]:

Pushed to master.

Comment 6 Isaque Galdino 2017-06-11 19:01:50 UTC

Review of attachment 352424 [details] [review]:

Hey, I have git commit --author=your name to it, so thanks for your work.