After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782996 - build: Use AM_TESTS_ENVIRONMENT rather than TESTS_ENVIRONMENT
build: Use AM_TESTS_ENVIRONMENT rather than TESTS_ENVIRONMENT
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2017-05-23 12:29 UTC by Philip Withnall
Modified: 2017-05-23 18:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Use AM_TESTS_ENVIRONMENT rather than TESTS_ENVIRONMENT (2.66 KB, patch)
2017-05-23 12:29 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2017-05-23 12:29:38 UTC 
Trivial patch attached, but needs some close review as it changes the glib-tap.mk copyscript.
Comment 1 Philip Withnall 2017-05-23 12:29:46 UTC 
Created attachment 352417 [details] [review]
build: Use AM_TESTS_ENVIRONMENT rather than TESTS_ENVIRONMENT

TESTS_ENVIRONMENT is reserved for the user to be able to set when
running the tests. AM_TESTS_ENVIRONMENT is for the tests’ Makefile to
set itself.

https://www.gnu.org/software/automake/manual/html_node/Scripts_002dbased-Testsuites.html

Signed-off-by: Philip Withnall <withnall@endlessm.com>
Comment 2 Colin Walters 2017-05-23 17:52:57 UTC 
Review of attachment 352417 [details] [review]:

LGTM. Changing glib-tap.mk seems safe enough to me since it's not installed; consumers will have to explicitly re-copy.
Comment 3 Philip Withnall 2017-05-23 18:16:59 UTC 
Attachment 352417 [details] pushed as a05b64a - build: Use AM_TESTS_ENVIRONMENT rather than TESTS_ENVIRONMENT