After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782994 - Port to meson build system
Port to meson build system
Status: RESOLVED FIXED
Product: libgepub
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libgepub Maintainer(s)
libgepub Maintainer(s)
Depends on:
Blocks: 782980
 
 
Reported: 2017-05-23 11:41 UTC by Iñigo Martínez
Modified: 2017-06-22 15:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Port to meson build system (12.68 KB, patch)
2017-05-23 11:41 UTC, Iñigo Martínez 		committed Details | Review

Description Iñigo Martínez 2017-05-23 11:41:10 UTC 
Created attachment 352406 [details] [review]
Port to meson build system

Complete port to meson build system.

- Taking advantage of the nature of meson, it will create the library as static or shared optionally.
- Test framework has been setup, but actually it's not aplicable.
- Added a confgiure_meson file to ease the configuration.
Comment 1 Daniel Garcia 2017-05-23 12:45:23 UTC 
Attachment 352406 [details] pushed as 97b173c - Port to meson build system
Comment 2 Bastien Nocera 2017-06-22 08:51:30 UTC 
FYI, the symbol exporting is completely incorrect, -export-symbols-regex is a libtool command, not an "ld" one. See this FAQ:
http://mesonbuild.com/FAQ.html#how-do-i-do-the-equivalent-of-libtools-exportsymbol-and-exportregex

See https://bugzilla.gnome.org/show_bug.cgi?id=784081
Comment 3 Iñigo Martínez 2017-06-22 15:51:58 UTC 
Too bad I wasn't fully aware of the problem. I have created a symbol visibility map, though adding a visibility attribute to the functions would also be nice (at least that is what I'm used to[0]).

I have created a new bug with a patch[1] for this.

Thank you!

[0] https://github.com/inigomartinez/libcc2540
[1] https://bugzilla.gnome.org/show_bug.cgi?id=784097