After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782977 - pty: pty_name is unused
pty: pty_name is unused
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-23 07:54 UTC by Debarshi Ray
Modified: 2017-05-23 10:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
pty: Removed unused variable (666 bytes, patch)
2017-05-23 07:58 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2017-05-23 07:54:20 UTC 
commit b59d76a5073d789f2f948cf928e883cb70cc8a75 added the pty_name variable which was never used. Let's remove it.
Comment 1 Debarshi Ray 2017-05-23 07:56:15 UTC 
Damn. Bugzilla failed to create the hyperlink. It is https://git.gnome.org/browse/vte/commit/?id=b59d76a5073d789f2f948cf928e883cb70cc8a75

commit b59d76a5073d789f2f948cf928e883cb70cc8a75
Author: Christian Persch <chpe@gnome.org>
Date:   Sun Nov 29 20:57:54 2015 +0100

    pty: Always acquire the child FD by name
    
    This saves one file descriptor per terminal in gnome-terminal for the
    case where we open the PTY master with BSD openpty().
Comment 2 Debarshi Ray 2017-05-23 07:58:37 UTC 
Created attachment 352388 [details] [review]
pty: Removed unused variable
Comment 3 Debarshi Ray 2017-05-23 10:31:49 UTC 
Comment on attachment 352388 [details] [review]
pty: Removed unused variable

Thanks for the quick review. Pushed to master, vte-0-48 and vte-0-46.