After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782962 - tests: start porting to meson
tests: start porting to meson
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other All
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-22 17:04 UTC by Mathieu Duponchelle
Modified: 2017-06-07 18:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
tests: start porting to meson (6.25 KB, patch)
2017-05-22 17:04 UTC, Mathieu Duponchelle
committed Details | Review

Description Mathieu Duponchelle 2017-05-22 17:04:25 UTC
Incomplete port, to get the ball rolling
Comment 1 Mathieu Duponchelle 2017-05-22 17:04:29 UTC
Created attachment 352369 [details] [review]
tests: start porting to meson
Comment 2 Tim-Philipp Müller 2017-06-07 11:53:51 UTC
Comment on attachment 352369 [details] [review]
tests: start porting to meson

So weird. I could swear I'd done this already.

In any case, please push if it works for you :)
Comment 3 Thibault Saunier 2017-06-07 15:36:50 UTC
Review of attachment 352369 [details] [review]:

Apart from that go.

::: tests/check/meson.build
@@ +72,3 @@
+# case where GStreamer is another subproject here.
+if not meson.is_subproject()
+  pkgconfig = find_program('pkg-config')

Please use:

if gst_dep.type_name() == 'pkgconfig'
  pluginsdirs = [gst_dep.get_pkgconfig_variable('pluginsdir')] + [gst_base_dep.get_pkgconfig_variable('pluginsdir')]
endif

or so (see https://phabricator.freedesktop.org/diffusion/GSTBASE/browse/master/tests/check/meson.build;398a6a2a1b0f781d261a91aa967c52b08d894098$98)
Comment 4 Mathieu Duponchelle 2017-06-07 18:48:11 UTC
Yep, it passes, though the camerabin test takes 1 minute
to do so here, not sure why

Attachment 352369 [details] pushed as 794ada0 - tests: start porting to meson