After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782943 - [review] some cleanup of clients/nmcli meta data (th/clients-meta-cleanup-bgo782943)
[review] some cleanup of clients/nmcli meta data (th/clients-meta-cleanup-bgo...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-05-22 09:17 UTC by Thomas Haller
Modified: 2017-05-23 11:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Thomas Haller 2017-05-22 09:17:27 UTC 
please review
Comment 1 Beniamino Galvani 2017-05-23 06:47:42 UTC 
> clients: implement wired-wake-on-lan property as enum

The list of allowed values is empty:

 Error: failed to modify 802-3-ethernet.wake-on-lan: invalid option 'aaa', use one of [].

> clients: implement proxy-mode property as enum

s/mode/method/

Pushed a fixup. The rest looks good to me.
Comment 2 Thomas Haller 2017-05-23 09:27:29 UTC 
(In reply to Beniamino Galvani from comment #1)
> > clients: implement wired-wake-on-lan property as enum
> 
> The list of allowed values is empty:
> 
>  Error: failed to modify 802-3-ethernet.wake-on-lan: invalid option 'aaa',
> use one of [].

Thanks. Fixed by "clients: fix error message for setting flags enums"
    

Repushed.
Comment 3 Thomas Haller 2017-05-23 11:50:51 UTC 
merged (after ACK from Lubomir on IRC)

https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=260fd3e79f8decef7fd85c3ca00f6ec69dbe3678