After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782930 - util: Always use 12h format if requested
util: Always use 12h format if requested
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2017-05-21 19:33 UTC by Florian Müllner
Modified: 2017-05-22 13:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
util: Always use 12h format if requested (1.95 KB, patch)
2017-05-21 19:33 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2017-05-21 19:33:12 UTC 
See patch. Unlike both the other components mentioned in the commit message, we don't actually query the locale for AM/PM support, so our check already picks up the GDateTime change correctly. But then it doesn't make sense for us to include a condition that non-obviously always evaluates to true ...
Comment 1 Florian Müllner 2017-05-21 19:33:17 UTC 
Created attachment 352315 [details] [review]
util: Always use 12h format if requested

Whether we show times in 12h format currently depends on:
 - the 'clock-format' desktop setting
 - the locale support for AM/PM

This was consist with other GNOME components, however both the
WallClock[0] and the Date+Time Settings panel[1] dropped the
second check after GDateTime started supporting AM/PM independently
from the locale, so we should follow suite.

[0] https://git.gnome.org/browse/gnome-desktop/commit?id=226fe725ef2cb2
[1] https://git.gnome.org/browse/gnome-control-center/commit?id=85cd910af
Comment 2 Rui Matos 2017-05-22 12:44:13 UTC 
Review of attachment 352315 [details] [review]:

yep
Comment 3 Florian Müllner 2017-05-22 13:42:04 UTC 
Attachment 352315 [details] pushed as 817ff52 - util: Always use 12h format if requested