After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782917 - qmlglsink: Add dummy black texture as placeholder for NULL buffers
qmlglsink: Add dummy black texture as placeholder for NULL buffers
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-21 13:33 UTC by Carlos Rafael Giani
Modified: 2017-05-21 14:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
qmlglsink dummy black texture patch (3.49 KB, patch)
2017-05-21 13:36 UTC, Carlos Rafael Giani
committed Details | Review

Description Carlos Rafael Giani 2017-05-21 13:33:50 UTC
Currently, the GstQSGTexture bind() function doesn't really do anything if a null GstBuffer pointer is supplied. This results in some random pixels being shown, because an invalid texture is used in the QSGNode. Fix this by binding an internal dummy black 64x64 RGBA texture if the GstBuffer pointer is NULL.
Comment 1 Carlos Rafael Giani 2017-05-21 13:36:02 UTC
Created attachment 352275 [details] [review]
qmlglsink dummy black texture patch

Here is a patch for introducing this dummy texture.
Comment 2 Matthew Waters (ystreet00) 2017-05-21 14:54:29 UTC
commit f191bf0c116b3b014919e7207384af47c9882da2
Author: Carlos Rafael Giani <dv@pseudoterminal.org>
Date:   Sun May 21 15:26:12 2017 +0200

    qmlglsink: Add dummy texture that is shown as placeholder for NULL buffers
    
    https://bugzilla.gnome.org/show_bug.cgi?id=782917