After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782867 - gst-omx: plugin stays blacklisted even when modifying gstomx.conf or GST_OMX_CONFIG_DIR
gst-omx: plugin stays blacklisted even when modifying gstomx.conf or GST_OMX_...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-omx
1.13.x
Other All
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-20 14:20 UTC by Julien Isorce
Modified: 2017-05-21 14:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
omx: allow 0 feature (1.72 KB, patch)
2017-05-20 14:28 UTC, Julien Isorce 		committed Details | Review

Description Julien Isorce 2017-05-20 14:20:31 UTC 
In practice it is only annoying at development time. But then I found this is also not consistent with other auto-generated plugins like gst-{ffmpeg,libav} and gstreamer-vaapi which always return TRUE from plugin_init. Let's do the same for gst-omx.
Comment 1 Julien Isorce 2017-05-20 14:28:55 UTC 
Created attachment 352224 [details] [review]
omx: allow 0 feature
Comment 2 Tim-Philipp Müller 2017-05-21 12:00:33 UTC 
Comment on attachment 352224 [details] [review]
omx: allow 0 feature

Worksforme
Comment 3 Julien Isorce 2017-05-21 14:45:16 UTC 
Comment on attachment 352224 [details] [review]
omx: allow 0 feature

Author: Julien Isorce <jisorce@oblong.com>
Date:   Sat May 20 14:49:20 2017 +0100

    omx: allow 0 feature
    
    Previously the omx plugin was blacklisted if GST_OMX_CONFIG_DIR
    points to an invalid path or if the gstomx.conf contains 0 valid
    component.
    Problem is that once the plugin is blacklisted, a rescan is not
    triggered upon changes of the env var or the gstomx.conf file
    despite being setup with gst_plugin_add_dependency.
    
    This also makes it more consistent with other plugins that auto
    generate features. For example gst-{ffmeg,libav}, gstreamer-vaapi,
    v4l2 video dec.
    
    To clarify the diff, the plugin_init func will return TRUE even if
    g_key_file_get_groups returns 0 element and even if
    g_key_file_load_from_dirs fails.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=782867