After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782802 - tests/unit/markup.js: TypeError: Calendar._fixMarkup is not a function
tests/unit/markup.js: TypeError: Calendar._fixMarkup is not a function
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: calendar
3.24.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2017-05-18 18:04 UTC by Jeremy Bicha
Modified: 2017-05-19 12:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build log (836.11 KB, text/plain)
2017-05-18 18:04 UTC, Jeremy Bicha 		  Details
tests: Update markup test for function moved to messageList (1.75 KB, patch)
2017-05-18 19:47 UTC, Jeremy Bicha 		committed Details | Review

Description Jeremy Bicha 2017-05-18 18:04:05 UTC 
Created attachment 352113 [details]
build log

Ubuntu 17.04
gnome-shell 3.24.2

I'm trying to run the gnome-shell test suite but the markup.js unit test is failing.

Full build log attached.

Build Log Excerpt
-----------------
   JS IMPORT: successfully imported module 'calendar'

(markup.js:24138): Gjs-WARNING **: JS ERROR: TypeError: Calendar._fixMarkup is not a function
assertConverts@tests/unit/markup.js:19:17
@tests/unit/markup.js:48:1

JS_EvaluateScript() failed
Comment 1 Jeremy Bicha 2017-05-18 19:47:46 UTC 
Created attachment 352116 [details] [review]
tests: Update markup test for function moved to messageList

https://git.gnome.org/browse/gnome-shell/commit/?id=ee8fd1e6

Wow, this broke with GNOME 3.20, so I'd like to backport this to 3.24, 3.22 and 3.20 then even though 3.20 is unlikely to get another release.
Comment 2 Florian Müllner 2017-05-19 10:42:34 UTC 
Review of attachment 352116 [details] [review]:

OK
Comment 3 Jeremy Bicha 2017-05-19 12:30:38 UTC 
Attachment 352116 [details] pushed as 9d53a77 - tests: Update markup test for function moved to messageList