GNOME Bugzilla – Bug 782782
Merge valadoc source into vala 0.37.x
Last modified: 2017-09-27 15:11:25 UTC
I am in favour of merging the valadoc source into vala itself to reduce maintenance work. So while valadoc can be considered a part of the vala-toolchain and is better to have it live in a combined repository. While valadoc never had an official release before its 0.36.0, the availability in distributions is/was quite low.
https://git.gnome.org/browse/vala/log/?h=wip/merge-valadoc
I have mixed feelings about merging both repositories. However, I am okay with it as long as you keep my commit-history.
@flo: I see, so please describe a way for how to accomplish that.
Created attachment 354418 [details] Migrates valadoc to vala Hey Rico, I prepared a branch but had no time to pick-up my private key from home. Here is a script that re-creates all steps.
@flo: Pushed a new branch which includes the git history https://git.gnome.org/browse/vala/log/?h=wip/valadoc
commit 2b742fce82eb1326faaee3b2cc4ff993e701ef53 Merge: 7609126be 93d9fe647 Author: Rico Tzschichholz <ricotz@ubuntu.com> Date: Tue Jun 27 13:09:30 2017 +0200 Merge valadoc 0.36.0 Consider valadoc a part of vala's toolchain and therefore let it live in the main repository. With this merge there is no need to maintain multiple driver sources since only one is required from now on. There is no dependency on gee-0.8 and vala's internal gee copy has made to be sufficient. The libvaladoc library will be suffixed with vala's version suffix too. Besides this renaming the rest of the valadoc file layout is kept the same.
This makes vala depend on graphviz now. Can valadoc building at least be made optional? Thanks.
(In reply to Armin K. from comment #7) > This makes vala depend on graphviz now. Can valadoc building at least be > made optional? Thanks. See https://bugzilla.gnome.org/show_bug.cgi?id=787375
Should something be done with the valadoc.git repository to make it more obvious that valadoc now lives in Vala? For example, put an obvious notice in README, or empty the repository and leave *only* the README file.
(In reply to Philip Withnall from comment #9) > Should something be done with the valadoc.git repository to make it more > obvious that valadoc now lives in Vala? For example, put an obvious notice > in README, or empty the repository and leave *only* the README file. Good idea. I think the README should be updated and the repository archived: https://git.gnome.org/browse/archive/
The original repository is still required to vala < 0.38. Currently I still intend to support 0.34 and 0.36 branches of vala.
(In reply to Rico Tzschichholz from comment #11) > The original repository is still required to vala < 0.38. > Currently I still intend to support 0.34 and 0.36 branches of vala. Right, but its README file could still be changed to mention that development has moved to vala.git, right?
@philip: Yes, but I guess I will cherry pick some already made fixes.