GNOME Bugzilla – Bug 782772
retro: Libretro cores should have an appropriate save directory
Last modified: 2017-05-18 13:05:19 UTC
Currently the save directory assigned to Libretro cores is "." which is very wrong, we should instead have one in the regular save directory using the game's GUID.
Created attachment 352083 [details] [review] video: Make CairoDisplay.set_core() accept null This will help releasing references on the core.
Created attachment 352084 [details] [review] audio: Make PaPlayer.set_core() accept null This will help releasing references on the core.
Attachment 352083 [details] pushed as fca1ea4 - video: Make CairoDisplay.set_core() accept null Attachment 352084 [details] pushed as c1309b8 - audio: Make PaPlayer.set_core() accept null
Created attachment 352095 [details] [review] retro: Set the save dir of the core
Created attachment 352096 [details] [review] retro: Remove core from audio and video outputs This will help ensuring we don't use the core we want to free anymore.
Created attachment 352097 [details] [review] retro: Deinit RetroRunner on destruction This helps ensuring we unload the game, deinit the core, and by extension that cores saving on unload save as expected.
Created attachment 352098 [details] [review] ui: Stop core instead of pausing it on quit When using RetroRunner, this helps ensuring we unload the game, deinit the core, and by extension that cores saving on unload save as expected when quitting the application.
Attachment 352095 [details] pushed as 2ffd5e5 - retro: Set the save dir of the core Attachment 352096 [details] pushed as fa418d2 - retro: Remove core from audio and video outputs Attachment 352097 [details] pushed as 9c40b4a - retro: Deinit RetroRunner on destruction Attachment 352098 [details] pushed as 378b4c4 - ui: Stop core instead of pausing it on quit