After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782749 - AT-SPI2 is missing roles that are present in ATK
AT-SPI2 is missing roles that are present in ATK
Status: RESOLVED FIXED
Product: pyatspi2
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Joanmarie Diggs (IRC: joanie)
At-spi maintainer(s)
Depends on: 782041
Blocks:
 
 
Reported: 2017-05-17 16:24 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2019-03-27 20:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (1.49 KB, patch)
2017-05-17 16:50 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2017-05-17 16:24:18 UTC 
+++ This bug was initially created as a clone of Bug #782041 +++

Bug 720065 resulted in several roles being added to ATK. Making the corresponding change in AT-SPI2 seems to have never happened. In particular, these roles seem absent:

* ATK_ROLE_DESCRIPTION_LIST
* ATK_ROLE_DESCRIPTION_TERM
* ATK_ROLE_DESCRIPTION_VALUE

https://git.gnome.org/browse/atk/commit/?id=9cd7ce3812

N.B. This bug depends on bug 782041 because we need the role in at-spi2-core first.
Comment 1 Joanmarie Diggs (IRC: joanie) 2017-05-17 16:50:21 UTC 
Created attachment 352038 [details] [review]
proposed patch

Please review. Thanks!
Comment 2 Mike Gorse 2017-05-18 18:10:48 UTC 
Comment on attachment 352038 [details] [review]
proposed patch

Looks good. Thanks for the patch.
Comment 3 Joanmarie Diggs (IRC: joanie) 2017-05-18 18:39:35 UTC 
Comment on attachment 352038 [details] [review]
proposed patch

Thanks for the review, Mike! Committed: https://git.gnome.org/browse/pyatspi2/commit/?id=1897e9b