GNOME Bugzilla – Bug 782748
AT-SPI2 is missing roles that are present in ATK
Last modified: 2017-05-18 18:33:20 UTC
+++ This bug was initially created as a clone of Bug #782041 +++ Bug 720065 resulted in several roles being added to ATK. Making the corresponding change in AT-SPI2 seems to have never happened. In particular, these roles seem absent: * ATK_ROLE_DESCRIPTION_LIST * ATK_ROLE_DESCRIPTION_TERM * ATK_ROLE_DESCRIPTION_VALUE https://git.gnome.org/browse/atk/commit/?id=9cd7ce3812 N.B. This bug depends on bug 782041 because we need the role in at-spi2-core first.
Created attachment 352037 [details] [review] proposed patch Note that this patch bumps the at-spi2-core dependency to version 2.25.1. Technically, it should be 2.25.2 -- assuming the patch for bug 782041 lands and winds up in the 2.25.2 release. I went with the .1 micro version so that at-spi2-atk would build but at the same time hint strongly at the fact that at-spi2-core would almost certainly need to be upgraded as well. Please review. Thanks!
Comment on attachment 352037 [details] [review] proposed patch I've bumped the at-spi2-core version to 2.25.2 (I really should have done this after rolling the 2.25.1 release anyhow). We should check for version 2.25.2; you can make that change before committing if you'd like. Anyhow, the patch looks fine.
Comment on attachment 352037 [details] [review] proposed patch (In reply to Mike Gorse from comment #2) > Comment on attachment 352037 [details] [review] [review] > proposed patch > > I've bumped the at-spi2-core version to 2.25.2 (I really should have done > this after rolling the 2.25.1 release anyhow). We should check for version > 2.25.2; you can make that change before committing if you'd like. Anyhow, > the patch looks fine. Thanks for the review. Committed with the updated version check: https://git.gnome.org/browse/at-spi2-atk/commit/?id=28bf17e