GNOME Bugzilla – Bug 782739
Add support for maxima, an open-source computer algebra system
Last modified: 2017-05-21 12:11:24 UTC
Created attachment 352018 [details] [review] The patch that adds maxima syntax highlighting to libgtksourceview. Maxima is an open-source computer algebra system that is used in many schools, firms and universities. It is quite powerful - and on its mailing list I've just found a link to a repo containing a language spec for libgtksourceview. This spec was gpl'ed => handing in a patch.
Review of attachment 352018 [details] [review]: Thanks for the *.lang file. The license header is not formatted the same as other *.lang files. Copy for example the license header of c.lang and adapt the copyrights. The license is the LGPLv2.1+. Also, the indentation must be with 2 spaces. Other than that, since I know nothing about Maxima I suppose the *.lang file is correct.
I've opened a few source files of maxima - and the syntax highlighting seems to indicate that the file is correct => Trying to attach the patch that corrects both issues you found. Kind regards, Gunter.
Created attachment 352266 [details] [review] The corrected version of the patch that adds support for maxima, a full-featured open-source computer algebra system.
Created attachment 352267 [details] [review] The corrected version of the patch that adds support for maxima, a full-featured open-source computer algebra system.
My first try to upload the corrected file didn't work (he error was on my side). But the currently attached version should work now.
Thanks, I've pushed commit 0730022fba9800cb13a4a6b75a7afd40b3fa8248 on the master branch (what will become GtkSourceView 4).
The commit message was not well formatted, see: https://wiki.gnome.org/Git/CommitMessages (but it was a small issue, I've fixed it).
Thanks a lot! And thanks for the pointer to the wiki page: My next patch will be correct in this respekt.