After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782703 - rtpvp8depay: do not mark output buffer as discont if PictureID is the expected
rtpvp8depay: do not mark output buffer as discont if PictureID is the expected
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.8.3
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-16 17:30 UTC by Miguel París Díaz
Modified: 2018-11-03 15:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
rtpbasedepayload: add function to clear discont flag (2.10 KB, patch)
2017-05-16 17:31 UTC, Miguel París Díaz
none Details | Review
rtpvp8depay: clear discont flag based on PictureID (3.47 KB, patch)
2017-05-16 17:32 UTC, Miguel París Díaz
none Details | Review
rtpvp8depay: clear discont flag based on PictureID (3.85 KB, patch)
2017-05-17 08:57 UTC, Miguel París Díaz
none Details | Review
rtpvp8depay: clear discont flag based on PictureID (3.37 KB, patch)
2017-05-17 09:40 UTC, Miguel París Díaz
none Details | Review

Description Miguel París Díaz 2017-05-16 17:30:31 UTC
Hello,
I have found a situation where some missed VP8 RTP packets are never retransmitted (requested by NACKs) due to they are not needed to decode the video.
Although they are not needed, RtpVp8Depay is marking the related output buffers as DISCONT, making some downstream elements to think that the VP8 stream is broken, but it isn't.
Comment 1 Miguel París Díaz 2017-05-16 17:31:45 UTC
Created attachment 351985 [details] [review]
rtpbasedepayload: add function to clear discont flag
Comment 2 Miguel París Díaz 2017-05-16 17:32:19 UTC
Created attachment 351986 [details] [review]
rtpvp8depay: clear discont flag based on PictureID
Comment 3 Miguel París Díaz 2017-05-17 08:57:48 UTC
Created attachment 352006 [details] [review]
rtpvp8depay: clear discont flag based on PictureID
Comment 4 Miguel París Díaz 2017-05-17 09:40:49 UTC
Created attachment 352011 [details] [review]
rtpvp8depay: clear discont flag based on PictureID
Comment 5 GStreamer system administrator 2018-11-03 15:19:07 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/373.