After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782661 - build: Install appstream metadata to /usr/share/metainfo/
build: Install appstream metadata to /usr/share/metainfo/
Status: RESOLVED FIXED
Product: gnome-software
Classification: Applications
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Software maintainer(s)
GNOME Software maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-05-15 16:52 UTC by Jeremy Bicha
Modified: 2017-05-18 11:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: Install appstream metadata to /usr/share/metainfo/ (3.64 KB, patch)
2017-05-15 16:52 UTC, Jeremy Bicha
none Details | Review
build: Install appstream metadata to /usr/share/metainfo/ (5.17 KB, patch)
2017-05-18 11:15 UTC, Jeremy Bicha
committed Details | Review

Description Jeremy Bicha 2017-05-15 16:52:33 UTC
There are two more things that need to be done here.

1. For the checkboxes to work correctly in the Addons section, I believe distros need to make sure each plugin has its own package with its own appstream addon metadata. No package should have more than one appstream metadata file. This affects contrib/gnome-software.spec.in

2. This should use /usr/share/metainfo/ in addition to /usr/share/appdata/ :
https://git.gnome.org/browse/gnome-software/tree/plugins/packagekit/gs-plugin-packagekit-refine.c#n881
Comment 1 Jeremy Bicha 2017-05-15 16:52:37 UTC
Created attachment 351908 [details] [review]
build: Install appstream metadata to /usr/share/metainfo/

This location has been recommended since appstream 0.9.4 a year ago
https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#spec-component-location
Comment 2 Jeremy Bicha 2017-05-18 03:14:09 UTC
Ok, let me clarify #1. If a distro wants the plugins to be individually installable/removable in the details page of gnome-software, then the plugins will need to be packaged separately and the plugin package should have just one appstream metadata file.

For instance, Debian and Ubuntu have 3 separate packages, one each for gnome-software-plugin-flatpak, -limba, and -snap. The gnome-software-plugin-flatpak package contains the .so for the Flatpak plugin and org.gnome.Software.Plugin.Flatpak.metainfo.xml and the package depends on the Flatpak package. Currently, in Ubuntu all the other plugins and their appstream metadata are stored in the regular gnome-software package because there currently isn't a big desire for those to be separately installable.

So with Ubuntu 17.10, a user will just need to check the appropriate Addon box in the GNOME Software details page to enable Flatpak Support.
Comment 3 Jeremy Bicha 2017-05-18 11:15:37 UTC
Created attachment 352082 [details] [review]
build: Install appstream metadata to /usr/share/metainfo/

This patch version updates the .spec file to match
Comment 4 Jeremy Bicha 2017-05-18 11:26:44 UTC
Attachment 352082 [details] pushed as a69e5df - build: Install appstream metadata to /usr/share/metainfo/