After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782658 - file-operations: mark_desktop_file_executable: deduplicate code
file-operations: mark_desktop_file_executable: deduplicate code
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-15 14:18 UTC by Ernestas Kulik
Modified: 2017-05-30 08:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
file-operations: mark_desktop_file_executable: deduplicate code (4.60 KB, patch)
2017-05-15 14:19 UTC, Ernestas Kulik 		committed Details | Review

Description Ernestas Kulik 2017-05-15 14:18:56 UTC 
Some duplicate code can be removed by refactoring the function.
Comment 1 Ernestas Kulik 2017-05-15 14:19:01 UTC 
Created attachment 351891 [details] [review]
file-operations: mark_desktop_file_executable: deduplicate code
Comment 2 Carlos Soriano 2017-05-29 15:16:07 UTC 
Review of attachment 351891 [details] [review]:

your tittle is too long. You can remove the function name.

Otherwise looks good!
Comment 3 Ernestas Kulik 2017-05-30 08:19:15 UTC 
Attachment 351891 [details] pushed as 80ebc12 - file-operations: deduplicate code