After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782650 - file-operations: use automatic cleanup
file-operations: use automatic cleanup
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-15 08:42 UTC by Ernestas Kulik
Modified: 2017-05-15 12:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
file-operations: create: use automatic cleanup (6.96 KB, patch)
2017-05-15 08:42 UTC, Ernestas Kulik 		committed Details | Review
file-operations: link: use automatic cleanup (2.97 KB, patch)
2017-05-15 08:43 UTC, Ernestas Kulik 		committed Details | Review
file-operations: move: use automatic cleanup (1.22 KB, patch)
2017-05-15 08:43 UTC, Ernestas Kulik 		committed Details | Review
file-operations: copy: use automatic cleanup (1.58 KB, patch)
2017-05-15 08:43 UTC, Ernestas Kulik 		committed Details | Review
file-operations: delete: use automatic cleanup (1.52 KB, patch)
2017-05-15 08:43 UTC, Ernestas Kulik 		committed Details | Review
file-operations: mark_desktop_file_executable: use automatic cleanup (1.29 KB, patch)
2017-05-15 08:43 UTC, Ernestas Kulik 		committed Details | Review
file-operations: empty_trash: use automatic cleanup (1.08 KB, patch)
2017-05-15 08:43 UTC, Ernestas Kulik 		committed Details | Review
file-operations: set_permissions_recursive: use automatic cleanup (1.25 KB, patch)
2017-05-15 08:43 UTC, Ernestas Kulik 		committed Details | Review
file-operations: duplicate: use automatic cleanup (1.35 KB, patch)
2017-05-15 08:43 UTC, Ernestas Kulik 		committed Details | Review

Description Ernestas Kulik 2017-05-15 08:42:48 UTC 
Makes things a bit more easy to follow.
Comment 1 Ernestas Kulik 2017-05-15 08:42:54 UTC 
Created attachment 351861 [details] [review]
file-operations: create: use automatic cleanup
Comment 2 Ernestas Kulik 2017-05-15 08:43:07 UTC 
Created attachment 351862 [details] [review]
file-operations: link: use automatic cleanup
Comment 3 Ernestas Kulik 2017-05-15 08:43:12 UTC 
Created attachment 351863 [details] [review]
file-operations: move: use automatic cleanup
Comment 4 Ernestas Kulik 2017-05-15 08:43:17 UTC 
Created attachment 351864 [details] [review]
file-operations: copy: use automatic cleanup
Comment 5 Ernestas Kulik 2017-05-15 08:43:21 UTC 
Created attachment 351865 [details] [review]
file-operations: delete: use automatic cleanup
Comment 6 Ernestas Kulik 2017-05-15 08:43:27 UTC 
Created attachment 351866 [details] [review]
file-operations: mark_desktop_file_executable: use automatic cleanup
Comment 7 Ernestas Kulik 2017-05-15 08:43:32 UTC 
Created attachment 351867 [details] [review]
file-operations: empty_trash: use automatic cleanup
Comment 8 Ernestas Kulik 2017-05-15 08:43:37 UTC 
Created attachment 351868 [details] [review]
file-operations: set_permissions_recursive: use automatic cleanup
Comment 9 Ernestas Kulik 2017-05-15 08:43:41 UTC 
Created attachment 351869 [details] [review]
file-operations: duplicate: use automatic cleanup
Comment 10 Carlos Soriano 2017-05-15 08:47:33 UTC 
Review of attachment 351861 [details] [review]:

yes
Comment 11 Carlos Soriano 2017-05-15 09:08:21 UTC 
Review of attachment 351862 [details] [review]:

yup, but do this before push:

::: src/nautilus-file-operations.c
@@ +6643,3 @@
            int           files_left)
 {
+    GFile *src_dir, *new_dest;

You can split those too
Comment 12 Carlos Soriano 2017-05-15 09:08:55 UTC 
Review of attachment 351863 [details] [review]:

+1
Comment 13 Carlos Soriano 2017-05-15 09:09:25 UTC 
Review of attachment 351864 [details] [review]:

Failed to publish review: Undefined subroutine &Bugzilla::Extension::Splinter::WebService::ThrowCodeError called at /loader/0x7f63c223ab68/Bugzilla/Extension/Splinter/WebService.pm line 61.
Comment 14 Carlos Soriano 2017-05-15 09:10:11 UTC 
Review of attachment 351865 [details] [review]:

^ is what you get when you try to accept_commit_now withouth comment :/
Comment 15 Carlos Soriano 2017-05-15 09:10:34 UTC 
Review of attachment 351866 [details] [review]:

y
Comment 16 Carlos Soriano 2017-05-15 09:10:46 UTC 
Review of attachment 351867 [details] [review]:

e
Comment 17 Carlos Soriano 2017-05-15 09:10:58 UTC 
Review of attachment 351868 [details] [review]:

s
Comment 18 Carlos Soriano 2017-05-15 09:11:15 UTC 
Review of attachment 351869 [details] [review]:

s
Comment 19 Ernestas Kulik 2017-05-15 12:07:20 UTC 
Attachment 351861 [details] pushed as caef877 - file-operations: create: use automatic cleanup
Attachment 351862 [details] pushed as 0406451 - file-operations: link: use automatic cleanup
Attachment 351863 [details] pushed as 48fd326 - file-operations: move: use automatic cleanup
Attachment 351864 [details] pushed as 8e8010d - file-operations: copy: use automatic cleanup
Attachment 351865 [details] pushed as b1d57bc - file-operations: delete: use automatic cleanup
Attachment 351866 [details] pushed as 0d207fa - file-operations: mark_desktop_file_executable: use automatic cleanup
Attachment 351867 [details] pushed as f673ae8 - file-operations: empty_trash: use automatic cleanup
Attachment 351868 [details] pushed as 7b7f0a1 - file-operations: set_permissions_recursive: use automatic cleanup
Attachment 351869 [details] pushed as 8a14b53 - file-operations: duplicate: use automatic cleanup