After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782618 - Updating flatpak apps triggers reboot
Updating flatpak apps triggers reboot
Status: RESOLVED FIXED
Product: gnome-software
Classification: Applications
Component: Flatpak
3.26.x
Other Linux
: Normal critical
: ---
Assigned To: Richard Hughes
Richard Hughes
Depends on:
Blocks:
 
 
Reported: 2017-05-14 14:30 UTC by Bastien Nocera
Modified: 2017-11-07 14:15 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Bastien Nocera 2017-05-14 14:30:11 UTC
gnome-software-3.24.1-1.fc26.x86_64

I clicked on "Update All" for the Flatpak apps in the Updates tab. I carried on using my computer and got a prompt which mentioned that my system would reboot in 60 seconds. Looks like the Flatpak apps and runtimes updates trigger an unnecessary reboot.

If I wasn't in front of the machine when I did that, it would have rebooted, and lost whatever data I had in my current session.
Comment 1 Richard Hughes 2017-05-14 17:36:18 UTC
(In reply to Bastien Nocera from comment #0)
> I clicked on "Update All" for the Flatpak apps in the Updates tab.

Was that the button in the headerbar (the blue button) or the one that handled just the pending live updates in the updates panel content area?
Comment 2 Bastien Nocera 2017-05-14 21:25:09 UTC
(In reply to Richard Hughes from comment #1)
> (In reply to Bastien Nocera from comment #0)
> > I clicked on "Update All" for the Flatpak apps in the Updates tab.
> 
> Was that the button in the headerbar (the blue button) or the one that
> handled just the pending live updates in the updates panel content area?

The one in the content area, just above the Flatpak apps section. There were also OS updates available, but I didn't want to reboot my machine, so didn't do those.
Comment 3 Richard Hughes 2017-05-15 10:15:59 UTC
commit ec035c1a27d827690952b5b0e864999290f38ae7
Author: Richard Hughes <richard@hughsie.com>
Date:   Mon May 15 11:12:30 2017 +0100

    Only try to restart after installing all non-live updates
    
    This moves the restart-detection logic to look at only the apps that were
    updated rather than all the apps that were available to be updated.
    
    Resolves: https://bugzilla.gnome.org/show_bug.cgi?id=782618

:100644 100644 ee605d71... 80b4e69a... M        src/gs-updates-page.c
Comment 4 krinkodot22 2017-09-17 03:17:31 UTC
I just experienced this issue today, on Gnome 3.24.2. To what branch was the fixing commit submitted?
Comment 5 Andreas Nilsson 2017-10-27 10:04:47 UTC
Running 3.26.1 here and I still get hit by this bug.
This happens consistently across 3 different machines here.

Happens both when I get only flatpak updates and I update via the button in the headerbar, and if I hit the "Update All" button in the Application Updates section (if I have both rpm-based package updates and flatpak updates at the same time).
Comment 6 Andreas Nilsson 2017-10-27 10:19:54 UTC
Here is part of the output when I ran gnome-software with --verbose.
Let me know if you need more from the output.
https://pastebin.com/UdU0Fz3g